You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/19 04:04:30 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #2677: Optimization of enumerated values method
codecov-commenter commented on pull request #2677:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2677#issuecomment-630565807
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=h1) Report
> Merging [#2677](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/772a8e2b3750ea7a0a615fb4a0a775fbd5af8fb4&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2677 +/- ##
============================================
+ Coverage 37.08% 37.11% +0.03%
Complexity 2550 2550
============================================
Files 434 434
Lines 19985 19994 +9
Branches 2423 2423
============================================
+ Hits 7411 7421 +10
+ Misses 11907 11904 -3
- Partials 667 669 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dolphinscheduler/common/enums/DbType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0RiVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/common/enums/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0NvbW1hbmRUeXBlLmphdmE=) | `80.00% <66.66%> (+7.27%)` | `3.00 <0.00> (+1.00)` | |
| [...dolphinscheduler/common/enums/ExecutionStatus.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0V4ZWN1dGlvblN0YXR1cy5qYXZh) | `61.76% <66.66%> (+6.92%)` | `3.00 <0.00> (+1.00)` | |
| [...duler/server/entity/DataxTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9EYXRheFRhc2tFeGVjdXRpb25Db250ZXh0LmphdmE=) | `35.00% <0.00%> (-60.00%)` | `7.00% <0.00%> (-6.00%)` | |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `54.41% <0.00%> (-4.42%)` | `16.00% <0.00%> (ø%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `68.25% <0.00%> (-3.18%)` | `13.00% <0.00%> (-1.00%)` | |
| [...nscheduler/server/entity/TaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `87.12% <0.00%> (+5.94%)` | `60.00% <0.00%> (+3.00%)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `37.28% <0.00%> (+27.11%)` | `3.00% <0.00%> (+2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=footer). Last update [772a8e2...cf626af](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2677?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org