You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/12/08 16:08:16 UTC
[PR] TSFile - remove from background_fetch plugin. [trafficserver]
SolidWallOfCode opened a new pull request, #10909:
URL: https://github.com/apache/trafficserver/pull/10909
`TSFile` and related plugin API are being deprecated. This removes those from the `background_fetch` plugin, along with some other clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on code in PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#discussion_r1431836944
##########
plugins/background_fetch/configs.h:
##########
Review Comment:
that extern DbgCtl Bg_dbg_ctl should probably be
DbgCtl Bg_dbg_ctl{PLUGIN_NAME};
Plugin will build as-is but not run like that due to the externed dbg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1847503902
> https://github.com/apache/trafficserver/blob/master/tests/gold_tests/cache/background_fill.test.py
Sorry I'm not seeing where/how this tests the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#discussion_r1431949771
##########
plugins/background_fetch/configs.h:
##########
Review Comment:
Could just add:
DbgCtl Bg_dbg_ctl{PLUGIN_NAME};
to config.cc .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1989487753
This was fixed with #10980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1847505755
Hmmm, I'll have to double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall closed pull request #10909: TSFile - remove from background_fetch plugin.
URL: https://github.com/apache/trafficserver/pull/10909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1847461051
Any way we could get an Au test for this plugin merged first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1847495804
https://github.com/apache/trafficserver/blob/master/tests/gold_tests/cache/background_fill.test.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#issuecomment-1882007154
@ezelkow1 is going to take over this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TSFile - remove from background_fetch plugin. [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on code in PR #10909:
URL: https://github.com/apache/trafficserver/pull/10909#discussion_r1431836944
##########
plugins/background_fetch/configs.h:
##########
Review Comment:
that extern DbgCtl Bg_dbg_ctl should probably be
static DbgCtl Bg_dbg_ctl{PLUGIN_NAME};
Plugin will build as-is but not run like that due to the externed dbg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org