You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by da...@apache.org on 2024/09/10 17:04:40 UTC

(beam) 01/02: Revert "Try deflaking test timing (#32351)"

This is an automated email from the ASF dual-hosted git repository.

damccorm pushed a commit to branch users/damccorm/test_fix
in repository https://gitbox.apache.org/repos/asf/beam.git

commit a255d783ddef3d0e20a67c3aa68273881aa84222
Author: Danny McCormick <da...@google.com>
AuthorDate: Tue Sep 10 12:54:54 2024 -0400

    Revert "Try deflaking test timing (#32351)"
    
    This reverts commit 7d6f6fb55bc9ffed3468828487132b039daacd3a.
---
 sdks/python/apache_beam/ml/inference/base_test.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sdks/python/apache_beam/ml/inference/base_test.py b/sdks/python/apache_beam/ml/inference/base_test.py
index 76772132784..359a372bc5b 100644
--- a/sdks/python/apache_beam/ml/inference/base_test.py
+++ b/sdks/python/apache_beam/ml/inference/base_test.py
@@ -887,12 +887,13 @@ class RunInferenceBaseTest(unittest.TestCase):
   def test_run_inference_timeout_does_garbage_collection(self):
     with tempfile.TemporaryDirectory() as tmp_dirname:
       tmp_path = os.path.join(tmp_dirname, 'tmp_filename')
+      expected_file_contents = 'Deleted FakeSlowModel'
       with TestPipeline() as pipeline:
         # Start with bad example which gets timed out.
         # Then provide plenty of time for GC to happen.
-        examples = [20] + [1] * 15 + [20, 20, 20]
+        examples = [20] + [1] * 15
         expected_good = [1] * 15
-        expected_bad = [20, 20, 20, 20]
+        expected_bad = [20]
         pcoll = pipeline | 'start' >> beam.Create(examples)
         main, other = pcoll | base.RunInference(
             FakeSlowModelHandler(
@@ -909,7 +910,7 @@ class RunInferenceBaseTest(unittest.TestCase):
 
       with open(tmp_path) as f:
         s = f.read()
-        self.assertNotEqual(s, '')
+        self.assertEqual(s, expected_file_contents)
 
   def test_run_inference_impl_inference_args(self):
     with TestPipeline() as pipeline: