You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/09 07:33:07 UTC

[GitHub] [kylin] tianhui5 opened a new pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

tianhui5 opened a new pull request #1314:
URL: https://github.com/apache/kylin/pull/1314


   
   ## Proposed changes
   
   bug fix of KYLIN-4628
   
   ## Types of changes
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1314:
URL: https://github.com/apache/kylin/pull/1314#issuecomment-671702058


   Thank you for your contribution , we will check this code change later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] tianhui5 commented on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
tianhui5 commented on pull request #1314:
URL: https://github.com/apache/kylin/pull/1314#issuecomment-665402575


   > Does this change solved the problem you described in the JIRA?
   
   Yes, of course. I describe it in JIRA briefly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1314:
URL: https://github.com/apache/kylin/pull/1314#issuecomment-656010587


   ## Pull Request Test Coverage Report for [Build 6125](https://coveralls.io/builds/31960876)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **4** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.003%**) to **28.056%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [query/src/main/java/org/apache/kylin/query/routing/QueryRouter.java](https://coveralls.io/builds/31960876/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2FQueryRouter.java#L59) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **3** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31960876/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L48) | 4 | 68.33% |
   <!-- | **Total:** | **4** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31960876/badge)](https://coveralls.io/builds/31960876) |
   | :-- | --: |
   | Change from base [Build 6117](https://coveralls.io/builds/31940525): |  -0.003% |
   | Covered Lines: | 26223 |
   | Relevant Lines: | 93466 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1314:
URL: https://github.com/apache/kylin/pull/1314#issuecomment-678758714


   This looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1314:
URL: https://github.com/apache/kylin/pull/1314


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls edited a comment on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1314:
URL: https://github.com/apache/kylin/pull/1314#issuecomment-656010587


   ## Pull Request Test Coverage Report for [Build 6227](https://coveralls.io/builds/32579332)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.0005%**) to **28.031%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [query/src/main/java/org/apache/kylin/query/routing/QueryRouter.java](https://coveralls.io/builds/32579332/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2FQueryRouter.java#L59) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **3** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/32579332/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   | [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/32579332/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 83.33% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32579332/badge)](https://coveralls.io/builds/32579332) |
   | :-- | --: |
   | Change from base [Build 6212](https://coveralls.io/builds/32477996): |  0.0005% |
   | Covered Lines: | 26229 |
   | Relevant Lines: | 93570 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org