You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/12/13 17:31:35 UTC
Review Request 41327: Fixed a race in Authentication tests where it
was possible to connect to a non yet routed endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41327/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Repository: mesos
Description
-------
The call to `ProcessBase::initialize()` occurs in an asyncrhonous way.
This allows processes to be used before the complete initialization
happens, which is particularly bad for `route` and `install` because
it allows HTTP clients to do request to possible non yet routed or
installed endpoints. This was apparent in the AuthenticationTests.
This patch fixes the race for such tests while a deeper discussion
occurs on the semantics of `ProcessBase::initialize()`
Diffs
-----
3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
3rdparty/libprocess/src/tests/http_tests.cpp 9fe27039416290296e43c6327c85721342d02cb9
Diff: https://reviews.apache.org/r/41327/diff/
Testing
-------
On OSX, and Ubuntu 14.04:
```bash
$ make -j8 check
$ ./3rdparty/libprocess/libprocess-tests --gtest_filter="HttpAuthenticationTest.*" --gtest_repeat=100000 --verbose --gtest_break_on_failure
```
Thanks,
Alexander Rojas
Re: Review Request 41327: Fixed a race in Authentication tests where
it was possible to connect to a non yet routed endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41327/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 11:40 a.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Update according to Ben Mahler's review.
Bugs: MESOS-4142
https://issues.apache.org/jira/browse/MESOS-4142
Repository: mesos
Description
-------
The call to `ProcessBase::initialize()` occurs in an asyncrhonous way.
This allows processes to be used before the complete initialization
happens, which is particularly bad for `route` and `install` because
it allows HTTP clients to do request to possible non yet routed or
installed endpoints. This was apparent in the AuthenticationTests.
This patch fixes the race for such tests while a deeper discussion
occurs on the semantics of `ProcessBase::initialize()`
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp 9fe27039416290296e43c6327c85721342d02cb9
Diff: https://reviews.apache.org/r/41327/diff/
Testing
-------
On OSX, and Ubuntu 14.04:
```bash
$ make -j8 check
$ ./3rdparty/libprocess/libprocess-tests --gtest_filter="HttpAuthenticationTest.*" --gtest_repeat=100000 --verbose --gtest_break_on_failure
```
Thanks,
Alexander Rojas
Re: Review Request 41327: Fixed a race in Authentication tests where
it was possible to connect to a non yet routed endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41327/
-----------------------------------------------------------
(Updated Dec. 13, 2015, 5:34 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Bugs: MESOS-4142
https://issues.apache.org/jira/browse/MESOS-4142
Repository: mesos
Description
-------
The call to `ProcessBase::initialize()` occurs in an asyncrhonous way.
This allows processes to be used before the complete initialization
happens, which is particularly bad for `route` and `install` because
it allows HTTP clients to do request to possible non yet routed or
installed endpoints. This was apparent in the AuthenticationTests.
This patch fixes the race for such tests while a deeper discussion
occurs on the semantics of `ProcessBase::initialize()`
Diffs
-----
3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
3rdparty/libprocess/src/tests/http_tests.cpp 9fe27039416290296e43c6327c85721342d02cb9
Diff: https://reviews.apache.org/r/41327/diff/
Testing
-------
On OSX, and Ubuntu 14.04:
```bash
$ make -j8 check
$ ./3rdparty/libprocess/libprocess-tests --gtest_filter="HttpAuthenticationTest.*" --gtest_repeat=100000 --verbose --gtest_break_on_failure
```
Thanks,
Alexander Rojas