You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/10 00:35:37 UTC
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5651
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
IMPALA-3671: Add SCRATCH_LIMIT query option.
Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
---
M docs/impala.ditamap
A docs/topics/impala_scratch_limit.xml
2 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/5651/1
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5651
to look at the new patch set (#2).
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
IMPALA-3671: Add SCRATCH_LIMIT query option.
Clarify comment about # of DataNodes.
Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
---
M docs/impala.ditamap
A docs/topics/impala_scratch_limit.xml
2 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/5651/2
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
IMPALA-3671: Add SCRATCH_LIMIT query option.
Clarify comment about # of DataNodes.
Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Reviewed-on: http://gerrit.cloudera.org:8080/5651
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
A docs/topics/impala_scratch_limit.xml
2 files changed, 101 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/16/
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
The technical content looks accurate.
http://gerrit.cloudera.org:8080/#/c/5651/1/docs/topics/impala_scratch_limit.xml
File docs/topics/impala_scratch_limit.xml:
PS1, Line 79: DataNodes
It's really the number of Impala daemons that determines this, right? Even if it's usually the same number.
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5651/1/docs/topics/impala_scratch_limit.xml
File docs/topics/impala_scratch_limit.xml:
PS1, Line 79: DataNodes
> It's really the number of Impala daemons that determines this, right? Even
Try, I'll clarify.
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option.
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I662a59a59da8a170a2710d4a5245363ae1e3f754
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No