You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by zenfenan <gi...@git.apache.org> on 2018/08/12 14:54:08 UTC
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2946
NIFI-5494: Added ExpressionLanguage support to 'Hive Configuration Re…
…sources'
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI5494CLONE
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2946
----
commit 3688fead662d65826a36c820a1c5064324ec9bf0
Author: zenfenan <si...@...>
Date: 2018-08-12T14:53:02Z
NIFI-5494: Added ExpressionLanguage support to 'Hive Configuration Resources'
----
---
[GitHub] nifi issue #2946: NIFI-5494: Added ExpressionLanguage support to 'Hive Confi...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2946
Hi @zenfenan - sorry it took so long, really busy for the last few weeks. It LGTM, merging to master, thanks for the improvement.
---
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2946
---
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r209458548
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java ---
@@ -133,6 +133,7 @@
+ "Please see the Hive documentation for more details.")
.required(false)
.addValidator(HiveUtils.createMultipleFilesExistValidator())
+ .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
--- End diff --
Same here L305, no?
---
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r209458600
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java ---
@@ -182,6 +182,7 @@
+ "Please see the Hive documentation for more details.")
.required(false)
.addValidator(HiveUtils.createMultipleFilesExistValidator())
+ .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
--- End diff --
Oops.. Extremely sorry.. My mistake. Cherry-picked the wrong commit. Let me fix this real quick.
---
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r211700721
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java ---
@@ -133,6 +133,7 @@
+ "Please see the Hive documentation for more details.")
.required(false)
.addValidator(HiveUtils.createMultipleFilesExistValidator())
+ .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
--- End diff --
It's fixed now. Appreciate if you could take a look.
---
[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r209458522
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java ---
@@ -182,6 +182,7 @@
+ "Please see the Hive documentation for more details.")
.required(false)
.addValidator(HiveUtils.createMultipleFilesExistValidator())
+ .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
--- End diff --
I think we are missing some EL evaluation in the code where this property is used. (L428 for instance)
---