You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/10 07:15:48 UTC

[GitHub] [spark] JkSelf commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

JkSelf commented on pull request #28669:
URL: https://github.com/apache/spark/pull/28669#issuecomment-641782521


   @manuzhang If you adjust the configuration of `spark.sql.adaptive.skewJoin.skewedPartitionFactor ` between  0 and 1, can the 13GB partition be split? If so, can we set the skewed related configurations to trigger the skew optimization not revert this PR? I think this PR is meaningful when the rule of `OptimizeSkewedJoin` is behind `CoalesceShufflePartitions` in the `queryStageOptimizerRules` of `AdaptiveSparkPlanExec`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org