You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hemanth Yamijala (JIRA)" <ji...@apache.org> on 2009/03/04 15:05:56 UTC

[jira] Created: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
------------------------------------------------------------------------------------------------------------------

                 Key: HADOOP-5395
                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
             Project: Hadoop Core
          Issue Type: Improvement
          Components: mapred
            Reporter: Hemanth Yamijala
            Assignee: rahul k singh
             Fix For: 0.21.0


When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:

org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
       at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
       at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
       at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
       at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
       at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
       at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 

The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681779#action_12681779 ] 

Hudson commented on HADOOP-5395:
--------------------------------

Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
    . Change the exception message when a job is submitted to an invalid queue. Contributed by Rahul Kumar Singh.


> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.20.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "rahul k singh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

rahul k singh updated HADOOP-5395:
----------------------------------

    Attachment: exceptionpath

attaching the fix and testcase.

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hemanth Yamijala updated HADOOP-5395:
-------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.21.0)
                   0.20.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I committed this to branch 0.20 and trunk. Thanks, Rahul !

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.20.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681368#action_12681368 ] 

Hemanth Yamijala commented on HADOOP-5395:
------------------------------------------

We ran tests, and all tests passed except: TestCLI (HADOOP-5477) and TestJobHistory (HADOOP-5391). Both these failures are not related to the current patch. On this ground, I am going to commit this.

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "rahul k singh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

rahul k singh updated HADOOP-5395:
----------------------------------

    Attachment: HADOOP-5395.patch

Incorporated  Hemanth's suggestions.

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680922#action_12680922 ] 

Hemanth Yamijala commented on HADOOP-5395:
------------------------------------------

Looking ok. Few minor comments:

- As we are doing in HADOOP-5327, we need to delete the system directory if the queue is invalid.
- The message seems to be printing an additional space around the queue name.
- Some formatting changes: there's a spurious space around the if condition; in the test case, indentation is not right in the exception block.
- setupConf("mapred.queue.names","default") is confusing, because setupConf is only for setting up ACLs. Maybe a job conf should be directly created.
- I would suggest we name the test method as something like testSubmissionToInvalidQueue or something like that.

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "rahul k singh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681290#action_12681290 ] 

rahul k singh commented on HADOOP-5395:
---------------------------------------

Result of testpatch    
 [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
     [exec]


> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681284#action_12681284 ] 

Hemanth Yamijala commented on HADOOP-5395:
------------------------------------------

Code changes look good. +1.

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5395) When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading

Posted by "rahul k singh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

rahul k singh updated HADOOP-5395:
----------------------------------

    Status: Patch Available  (was: Open)

> When queue ACLs are enabled, the error message shown when a job is submitted to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5395
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>             Fix For: 0.21.0
>
>         Attachments: exceptionpath, HADOOP-5395.patch
>
>
> When acls are enabled on the job tracker using the property mapred.acls.enabled, and a job is submitted to a queue name that does not exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException: org.apache.hadoop.security.AccessControlException: User user-name cannot perform operation SUBMIT_JOB on queue queue-name
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>        at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
>        at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58) 
> The message makes it appear like the queue exists, but the user does not have access to it, where the actual problem is that the queue does not exist at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.