You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 06:15:17 UTC

[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854391302


   > Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek. I have to exclude all the words right? mentioned in [#15994 (comment)](https://github.com/apache/airflow/issues/15994#issue-898308474). I need a little help in that.
   
   @Patil2099 yes, we should add similar hook to pre-commit-config as this one:
   https://github.com/apache/airflow/blob/476d0f6e3d2059f56532cda36cdc51aa86bafb37/.pre-commit-config.yaml#L333-L341
   The regexp should be like `(?i)(\bmaster\b|\bhe\b|\bshe\b|\bhis\b|\bher\b)` so we match exact word not substrings like `HElp`.
   Also we will need to adjust all occurrences of non-inclusive words. 
   
   
   > Thanks for taking on this! Is there any chance that `DummyOperator` can be renamed to something else, too? I've heard `dummy` may be a non-inclusive word, too.
   
   @ktmud that's interesting suggestion. This would be a breaking change but I think it's worth trying. Any suggestions for a new name? CC @leahecole @kaxil @potiuk 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org