[GitHub] [lucene-solr] murblanc commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

[GitBox <gi...@apache.org>]

murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552193376



##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaPosition.java
##########
@@ -19,17 +19,20 @@
 
 
 public class ReplicaPosition implements Comparable<ReplicaPosition> {

Review comment:
       It's not from this PR, but the text `Note: this class has a natural ordering that is inconsistent with equals.` should have been added to the class Javadoc that should have been here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org