You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Yan Fang <ya...@gmail.com> on 2014/08/21 01:47:15 UTC

Review Request 24917: SAMZA-361

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24917/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-361
    https://issues.apache.org/jira/browse/SAMZA-361


Repository: samza


Description
-------

Create org.apache.samza.util.Logging to replace Grizziled slf4j
Use the new Logging import
Remove dependencies in build.gradle


Diffs
-----

  build.gradle 357bb0e 
  samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 84ea4ca 
  samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 4efe997 
  samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala abcb034 
  samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala d71ead1 
  samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala 4cfdcc2 
  samza-core/src/main/scala/org/apache/samza/config/factories/PropertiesConfigFactory.scala 768cfa4 
  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 6862460 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 04edf50 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 92d48eb 
  samza-core/src/main/scala/org/apache/samza/container/TaskNamesToSystemStreamPartitions.scala 427119e 
  samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 19c9538 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala a9ecd97 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 74b9367 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala 0acc3de 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala c0ea0af 
  samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala 0ff88e7 
  samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala ed1e8af 
  samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala aac241b 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala d66efc2 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 319c74d 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 9711043 
  samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala 34c846c 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 0cfdbb3 
  samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 7f8bca7 
  samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala deb966b 
  samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala 928b47e 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BatchingChooser.scala 7120e62 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala ad21a08 
  samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala 52b8fc4 
  samza-core/src/main/scala/org/apache/samza/system/chooser/TieredPriorityChooser.scala e4232d3 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 9c99a59 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala c0e1bb6 
  samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala ec6b6f4 
  samza-core/src/main/scala/org/apache/samza/util/Logging.scala PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 16ad5a2 
  samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala d425e86 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fff62e4 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 087c6ad 
  samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 90e4041 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f094fa0 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 26fc187 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 662df99 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 2163d57 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3264cbd 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicMetadataCache.scala 9553050 
  samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0bc1867 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala b4e7178 
  samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 8e1493a 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 5764093 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala c084144 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala 4ad6312 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 51ee68f 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 7f8663d 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestPerformanceTask.scala 1661b43 
  samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 688e74e 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 2339960 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala c28c9a6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 8cb9490 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 28ed2c8 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ab13d43 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala d9dfbc6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 0dd244d 
  samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 85813b1 

Diff: https://reviews.apache.org/r/24917/diff/


Testing
-------


Thanks,

Yan Fang


Re: Review Request 24917: SAMZA-361

Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24917/#review51180
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/24917/#comment89201>

    Remove $grizzledVersion from all of the gradle/dependency-versions-*.gradle as well.


- Chris Riccomini


On Aug. 20, 2014, 11:47 p.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24917/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 11:47 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-361
>     https://issues.apache.org/jira/browse/SAMZA-361
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Create org.apache.samza.util.Logging to replace Grizziled slf4j
> Use the new Logging import
> Remove dependencies in build.gradle
> 
> 
> Diffs
> -----
> 
>   build.gradle 357bb0e 
>   samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 84ea4ca 
>   samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 4efe997 
>   samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala abcb034 
>   samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala d71ead1 
>   samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala 4cfdcc2 
>   samza-core/src/main/scala/org/apache/samza/config/factories/PropertiesConfigFactory.scala 768cfa4 
>   samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 6862460 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 04edf50 
>   samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 92d48eb 
>   samza-core/src/main/scala/org/apache/samza/container/TaskNamesToSystemStreamPartitions.scala 427119e 
>   samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 19c9538 
>   samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala a9ecd97 
>   samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 74b9367 
>   samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala 0acc3de 
>   samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala c0ea0af 
>   samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala 0ff88e7 
>   samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala ed1e8af 
>   samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala aac241b 
>   samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala d66efc2 
>   samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 319c74d 
>   samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 9711043 
>   samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala 34c846c 
>   samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 0cfdbb3 
>   samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 7f8bca7 
>   samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala deb966b 
>   samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala 928b47e 
>   samza-core/src/main/scala/org/apache/samza/system/chooser/BatchingChooser.scala 7120e62 
>   samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala ad21a08 
>   samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala 52b8fc4 
>   samza-core/src/main/scala/org/apache/samza/system/chooser/TieredPriorityChooser.scala e4232d3 
>   samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 9c99a59 
>   samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala c0e1bb6 
>   samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala ec6b6f4 
>   samza-core/src/main/scala/org/apache/samza/util/Logging.scala PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/util/Util.scala 16ad5a2 
>   samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala d425e86 
>   samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fff62e4 
>   samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 087c6ad 
>   samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 90e4041 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f094fa0 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 26fc187 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 662df99 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 2163d57 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3264cbd 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicMetadataCache.scala 9553050 
>   samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0bc1867 
>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala b4e7178 
>   samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 8e1493a 
>   samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 5764093 
>   samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala c084144 
>   samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala 4ad6312 
>   samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 51ee68f 
>   samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 7f8663d 
>   samza-test/src/main/scala/org/apache/samza/test/performance/TestPerformanceTask.scala 1661b43 
>   samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 688e74e 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 2339960 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala c28c9a6 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 8cb9490 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 28ed2c8 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ab13d43 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala d9dfbc6 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 0dd244d 
>   samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 85813b1 
> 
> Diff: https://reviews.apache.org/r/24917/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yan Fang
> 
>


Re: Review Request 24917: SAMZA-361

Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24917/
-----------------------------------------------------------

(Updated Aug. 22, 2014, 7:30 a.m.)


Review request for samza.


Changes
-------

* added slf4j-api dependency in samza-core
* changed calling Logger API in grazziled to extending org.apache.samza.util.Logging


Bugs: SAMZA-361
    https://issues.apache.org/jira/browse/SAMZA-361


Repository: samza


Description
-------

Create org.apache.samza.util.Logging to replace Grizziled slf4j
Use the new Logging import
Remove dependencies in build.gradle


Diffs (updated)
-----

  build.gradle 357bb0e 
  gradle/dependency-versions-scala-2.10.gradle ba54099 
  gradle/dependency-versions-scala-2.9.2.gradle 78d000f 
  samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 84ea4ca 
  samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 4efe997 
  samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala abcb034 
  samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala d71ead1 
  samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala 4cfdcc2 
  samza-core/src/main/scala/org/apache/samza/config/factories/PropertiesConfigFactory.scala 768cfa4 
  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 6862460 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 04edf50 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 92d48eb 
  samza-core/src/main/scala/org/apache/samza/container/TaskNamesToSystemStreamPartitions.scala 427119e 
  samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 19c9538 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala a9ecd97 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 74b9367 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala 0acc3de 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala c0ea0af 
  samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala 0ff88e7 
  samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala ed1e8af 
  samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala aac241b 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala d66efc2 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 319c74d 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 9711043 
  samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala 34c846c 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 0cfdbb3 
  samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 7f8bca7 
  samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala deb966b 
  samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala 928b47e 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BatchingChooser.scala 7120e62 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala ad21a08 
  samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala 52b8fc4 
  samza-core/src/main/scala/org/apache/samza/system/chooser/TieredPriorityChooser.scala e4232d3 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 9c99a59 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala c0e1bb6 
  samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala ec6b6f4 
  samza-core/src/main/scala/org/apache/samza/util/Logging.scala PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 16ad5a2 
  samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala d425e86 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fff62e4 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 087c6ad 
  samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 90e4041 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f094fa0 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 26fc187 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 662df99 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 2163d57 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3264cbd 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicMetadataCache.scala 9553050 
  samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0bc1867 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala b4e7178 
  samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 8e1493a 
  samza-kv-leveldb/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 6652f6b 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 5764093 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala c084144 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala 4ad6312 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 51ee68f 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 7f8663d 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestPerformanceTask.scala 1661b43 
  samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 688e74e 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 2339960 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala c28c9a6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 8cb9490 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 28ed2c8 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ab13d43 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala d9dfbc6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 0dd244d 
  samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 85813b1 

Diff: https://reviews.apache.org/r/24917/diff/


Testing
-------


Thanks,

Yan Fang


Re: Review Request 24917: SAMZA-361

Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24917/
-----------------------------------------------------------

(Updated Aug. 22, 2014, 6:25 a.m.)


Review request for samza.


Changes
-------

removed grizzledversions from more build scripts


Bugs: SAMZA-361
    https://issues.apache.org/jira/browse/SAMZA-361


Repository: samza


Description
-------

Create org.apache.samza.util.Logging to replace Grizziled slf4j
Use the new Logging import
Remove dependencies in build.gradle


Diffs (updated)
-----

  build.gradle 357bb0e 
  gradle/dependency-versions-scala-2.10.gradle ba54099 
  gradle/dependency-versions-scala-2.9.2.gradle 78d000f 
  samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 84ea4ca 
  samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 4efe997 
  samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala abcb034 
  samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala d71ead1 
  samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala 4cfdcc2 
  samza-core/src/main/scala/org/apache/samza/config/factories/PropertiesConfigFactory.scala 768cfa4 
  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 6862460 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 04edf50 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 92d48eb 
  samza-core/src/main/scala/org/apache/samza/container/TaskNamesToSystemStreamPartitions.scala 427119e 
  samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 19c9538 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala a9ecd97 
  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 74b9367 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala 0acc3de 
  samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala c0ea0af 
  samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala 0ff88e7 
  samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala ed1e8af 
  samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala aac241b 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala d66efc2 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 319c74d 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 9711043 
  samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala 34c846c 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 0cfdbb3 
  samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 7f8bca7 
  samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala deb966b 
  samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala 928b47e 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BatchingChooser.scala 7120e62 
  samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala ad21a08 
  samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala 52b8fc4 
  samza-core/src/main/scala/org/apache/samza/system/chooser/TieredPriorityChooser.scala e4232d3 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 9c99a59 
  samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala c0e1bb6 
  samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala ec6b6f4 
  samza-core/src/main/scala/org/apache/samza/util/Logging.scala PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 16ad5a2 
  samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala d425e86 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fff62e4 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 087c6ad 
  samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 90e4041 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala f094fa0 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 26fc187 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 662df99 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 2163d57 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3264cbd 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicMetadataCache.scala 9553050 
  samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0bc1867 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala b4e7178 
  samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 8e1493a 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 5764093 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala c084144 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala 4ad6312 
  samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 51ee68f 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 7f8663d 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestPerformanceTask.scala 1661b43 
  samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 688e74e 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 2339960 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala c28c9a6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 8cb9490 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 28ed2c8 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ab13d43 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala d9dfbc6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 0dd244d 
  samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 85813b1 

Diff: https://reviews.apache.org/r/24917/diff/


Testing
-------


Thanks,

Yan Fang