You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2014/05/22 12:21:02 UTC
[jira] [Assigned] (SLING-2920) Wrong handling of Sling Filter
ordering
[ https://issues.apache.org/jira/browse/SLING-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2920:
---------------------------------------
Assignee: Carsten Ziegeler
> Wrong handling of Sling Filter ordering
> ---------------------------------------
>
> Key: SLING-2920
> URL: https://issues.apache.org/jira/browse/SLING-2920
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.2.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Engine 2.3.4
>
> Attachments: SLING-2920.patch
>
>
> It looks like the ordering of Sling Filters is not implemented as it is documented on [1].
> The documented intent is:
> * service.ranking ordering with higher numbers being higher preference over lower numbers
> * filter.order ordering with lower numbers being higher preference over higher numbers
> * filter.order is ignored if service.ranking is defined
> * higher preferenced filters called before lower preferenced filters
> Actual implementation:
> * service.ranking ordering with lower numbers being higher preference over higher numbers
> * filter.order ordering with lower numbers being higher preference over higher numbers
> * filter.order is ignored if service.ranking is defined
> * higher preferenced filters called before lower preferenced filters
> As one can see, the service.ranking ordering is not properly implemented. It looks like this has been wrong since the first implementation as of SLING-1735 (Jan 2011).
> We can either live with this actual implementation and fix the documentation or fix the implementation at the cost of having to also fix any down-stream filter providers using service.ranking values as implemented (and not as documented).
> Discussion at http://sling.markmail.org/thread/h6uiveb2udw6y46q
> [1] http://sling.apache.org/documentation/the-sling-engine/filters.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)