You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Elliotte Rusty Harold (Jira)" <ji...@apache.org> on 2020/02/08 11:32:00 UTC
[jira] [Commented] (MSHADE-248) shading fails with "error in
opening zip file" if createSourcesJar=true and an invalid sources jar file
is encountered
[ https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032883#comment-17032883 ]
Elliotte Rusty Harold commented on MSHADE-248:
----------------------------------------------
I've certainly seen problems like this before, multiple times, though not with the shade plugin. In general it would be nice if Maven did validate files it downloads and reads from the local repo, and took a more deliberate approach about what to do when one is corrupt. Today a single corrupt file can cause weird, hard to understand failures with bad error messages far away from the root cause, depending mostly on which chunk of code notices and finally reacts to the error.
> shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.4.3
> Reporter: Ian Springer
> Priority: Major
>
> {code}
> Downloading: https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar: Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded: https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
> ------------------------------------------------------------------------
> BUILD FAILURE
> ------------------------------------------------------------------------
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project jclouds-shaded: Error creating shaded jar: error in opening zip file /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar -> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't control the fact that they have an invalid sources jar published, the shade plugin should be more forgiving and just log a warning and skip the bsh sources jar when building the shaded sources jar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)