You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2021/04/26 23:53:35 UTC

[kudu] branch master updated: KUDU-2612: more info on abandoned transaction tracking

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ce5def  KUDU-2612: more info on abandoned transaction tracking
2ce5def is described below

commit 2ce5def8746acae6229dba7b2fd362069eccd1fe
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Mon Apr 26 00:12:07 2021 -0700

    KUDU-2612: more info on abandoned transaction tracking
    
    This patch cross-references the --txn_staleness_tracker_interval_ms
    flag in the description of the --txn_keepalive_interval_ms one.
    That's useful for better understanding of how the abandoned transaction
    tracking works and how to properly change its parameters or disable it,
    if necessary.
    
    This patch doesn't contain any functional changes.
    
    Change-Id: I5b626f1f7e384efd616019013559f171ad7eaddc
    Reviewed-on: http://gerrit.cloudera.org:8080/17341
    Tested-by: Alexey Serbin <as...@cloudera.com>
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
 src/kudu/transactions/txn_status_manager.cc | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/kudu/transactions/txn_status_manager.cc b/src/kudu/transactions/txn_status_manager.cc
index 1a2e63e..3a7bef3 100644
--- a/src/kudu/transactions/txn_status_manager.cc
+++ b/src/kudu/transactions/txn_status_manager.cc
@@ -58,13 +58,15 @@
 #include "kudu/util/stopwatch.h"
 #include "kudu/util/threadpool.h"
 
-DEFINE_uint32(txn_keepalive_interval_ms, 30000,
+DEFINE_uint32(txn_keepalive_interval_ms, 30 * 1000, // 30 sec
               "Maximum interval (in milliseconds) between subsequent "
               "keep-alive heartbeats to let the transaction status manager "
               "know that a transaction is not abandoned. If the transaction "
-              "status manager does not receive a keepalive message for a "
-              "longer interval than the specified, the transaction is "
-              "automatically aborted.");
+              "status manager does not receive a keepalive message for a time "
+              "interval longer than the specified, the transaction is deemed "
+              "abandoned and automatically aborted. See the description of the "
+              "--txn_staleness_tracker_interval_ms flag for more information "
+              "on abandoned transactions tracking.");
 TAG_FLAG(txn_keepalive_interval_ms, experimental);
 TAG_FLAG(txn_keepalive_interval_ms, runtime);
 
@@ -82,7 +84,7 @@ DEFINE_int32(txn_status_manager_inject_latency_finalize_commit_ms, 0,
 TAG_FLAG(txn_status_manager_inject_latency_finalize_commit_ms, hidden);
 TAG_FLAG(txn_status_manager_inject_latency_finalize_commit_ms, unsafe);
 
-DEFINE_uint32(txn_staleness_tracker_interval_ms, 10000,
+DEFINE_uint32(txn_staleness_tracker_interval_ms, 10 * 1000,  // 10 sec
               "Period (in milliseconds) of the task that tracks and aborts "
               "stale/abandoned transactions. If this flag is set to 0, "
               "TxnStatusManager doesn't automatically abort stale/abandoned "