You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2017/05/06 10:05:32 UTC
Re: Review Request 56193: Use Docker cpus instead of cpu_share if
possible.
> On Mar 27, 2017, 8:38 po południu, Jie Yu wrote:
> > src/docker/docker.cpp
> > Lines 524 (patched)
> > <https://reviews.apache.org/r/56193/diff/1/?file=1621829#file1621829line524>
> >
> > Can you test if docker support arbitratry double here like 1.000001 (more than 3 digits after decimal point)?
> >
> > Also, looks like 0.000 means unlimited. I am wondering if we should set a MIN_CPUS here just to be consistent with the cpu share based semantics.
Yep, 0.000 means unlimited. Docker internay represnets cpus as [`NanoCPUs`](https://github.com/moby/moby/blob/a258ef58d8a100467d5d948b026a884ebe58eaf4/opts/opts.go#L344-L383). After introducting DockerRunOptions this patch makes no sense until docker deprecate old CPUs respurces API. I'll close it.
- Tomasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56193/#review170223
-----------------------------------------------------------
On Lut 1, 2017, 10:31 po południu, Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56193/
> -----------------------------------------------------------
>
> (Updated Lut 1, 2017, 10:31 po południu)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7006
> https://issues.apache.org/jira/browse/MESOS-7006
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Docker 1.13 introduces new flag `--cpus` for limiting cpu usage
> of a container. We can use this flag to avoid cpu share calculation
> and just pass cpus resources to Docker.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
>
>
> Diff: https://reviews.apache.org/r/56193/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>