You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Werner Punz (JIRA)" <de...@myfaces.apache.org> on 2009/09/21 14:12:16 UTC

[jira] Created: (MYFACES-2359) ComponentSystemEvents are not globally dispatched

ComponentSystemEvents are not globally dispatched
-------------------------------------------------

                 Key: MYFACES-2359
                 URL: https://issues.apache.org/jira/browse/MYFACES-2359
             Project: MyFaces Core
          Issue Type: Bug
          Components: JSR-314
    Affects Versions: 2.0.0-alpha
            Reporter: Werner Punz


The events triggered on component level should also dispatch global system events just like their siblings directly inherited from SystemEvent, a faces-config entry like

        <system-event-listener>
             <system-event-listener-class>mypackage.MyListener</system-event-listener-class>
            <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
         </system-event-listener>

currently does not do anything


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2359) ComponentSystemEvents are not globally dispatched

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz resolved MYFACES-2359.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-alpha

> ComponentSystemEvents are not globally dispatched
> -------------------------------------------------
>
>                 Key: MYFACES-2359
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2359
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Werner Punz
>             Fix For: 2.0.0-alpha
>
>
> The events triggered on component level should also dispatch global system events just like their siblings directly inherited from SystemEvent, a faces-config entry like
>         <system-event-listener>
>              <system-event-listener-class>mypackage.MyListener</system-event-listener-class>
>             <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
>          </system-event-listener>
> currently does not do anything

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2359) ComponentSystemEvents are not globally dispatched

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757882#action_12757882 ] 

Werner Punz commented on MYFACES-2359:
--------------------------------------

Ok I nailed the problem down, generally, the system itself works, the event dispatchers are added.
But the main issue is a discrepancy on how to handle the source class.

Currently if no source class is specified, then the source class is specified over the given constructor type for the source.
Which in case of the component events is UIComponent. Further granularisation can happen later.

The main issue is that myfaces dispatches the events over source.getClass instead of UIComponent.class.
I am not sure which approach is correct I have to do some blackbox testing against the RI for further clarification.



> ComponentSystemEvents are not globally dispatched
> -------------------------------------------------
>
>                 Key: MYFACES-2359
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2359
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Werner Punz
>
> The events triggered on component level should also dispatch global system events just like their siblings directly inherited from SystemEvent, a faces-config entry like
>         <system-event-listener>
>              <system-event-listener-class>mypackage.MyListener</system-event-listener-class>
>             <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
>          </system-event-listener>
> currently does not do anything

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2359) ComponentSystemEvents are not globally dispatched

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757885#action_12757885 ] 

Werner Punz commented on MYFACES-2359:
--------------------------------------

Ok a quick blackbox test against the RI revealed that the component class seems to be hardwired against UIComponent in this instance because doing a test against a UICommand as class did not do anything.



> ComponentSystemEvents are not globally dispatched
> -------------------------------------------------
>
>                 Key: MYFACES-2359
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2359
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Werner Punz
>
> The events triggered on component level should also dispatch global system events just like their siblings directly inherited from SystemEvent, a faces-config entry like
>         <system-event-listener>
>              <system-event-listener-class>mypackage.MyListener</system-event-listener-class>
>             <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
>          </system-event-listener>
> currently does not do anything

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2359) ComponentSystemEvents are not globally dispatched

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757897#action_12757897 ] 

Werner Punz commented on MYFACES-2359:
--------------------------------------

I have added direct references for the source class to UIComponent.class wherever it was needed


> ComponentSystemEvents are not globally dispatched
> -------------------------------------------------
>
>                 Key: MYFACES-2359
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2359
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Werner Punz
>             Fix For: 2.0.0-alpha
>
>
> The events triggered on component level should also dispatch global system events just like their siblings directly inherited from SystemEvent, a faces-config entry like
>         <system-event-listener>
>              <system-event-listener-class>mypackage.MyListener</system-event-listener-class>
>             <system-event-class>javax.faces.event.PreRenderComponentEvent</system-event-class>
>          </system-event-listener>
> currently does not do anything

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.