You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "mernst (via GitHub)" <gi...@apache.org> on 2023/04/11 17:16:21 UTC
[PR] Remove nonsensical documentation from `extractConverter()` (logging-log4j2)
mernst opened a new pull request, #1423:
URL: https://github.com/apache/logging-log4j2/pull/1423
The removed documentation, introduced in 3e6bb87f72, does not make sense.
* It states "the value null is returned", but the method return type is `int`.
* It talks about the value of the variable `i` after the method returns, but `i` is a local variable, not a class variable that would be visible after the method returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove nonsensical documentation from `extractConverter()` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #1423:
URL: https://github.com/apache/logging-log4j2/pull/1423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org