You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/16 09:25:11 UTC

[GitHub] [submarine] cdmikechen opened a new pull request #834: SUBMARINE-1126. Let Jupyter Notebook save user setting after pod restarted.

cdmikechen opened a new pull request #834:
URL: https://github.com/apache/submarine/pull/834


   ### What is this PR for?
   Jupyter Notebook have created a workspace volume `/home/jovyan/workspace` , but the user settings are saved in `/home/jovyan/.jupyter/lab/user-settings/@jupyterlab/`. 
   So that after pod restart, submarine will lost user settings. I think we should add a new volume to save user settings in `/home/jovyan/.jupyter/`.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [ x ] - Add a new PVC named `notebook-pvc-user-*` when creating notebook pod CRD
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1126
   
   ### How should this be tested?
   There are no new test cases right now.
   
   ### Screenshots (if appropriate)
   ![image](https://user-images.githubusercontent.com/12069428/146344069-5c92950b-cbd0-41d9-bc01-69625e9945a0.png)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? Maybe No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #834: SUBMARINE-1126. Let Jupyter Notebook save user setting after pod restarted.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #834:
URL: https://github.com/apache/submarine/pull/834


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org