You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/12 16:33:14 UTC
[GitHub] [tvm] Lunderberg opened a new pull request #8029: [Docs] Prevented docs/1 file from being generated.
Lunderberg opened a new pull request #8029:
URL: https://github.com/apache/tvm/pull/8029
Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-858127739
Next round of updates, tested locally against the newer version of sphinx used by CI, and rebased against main. Should have all build warnings fixed up through commit 1f2ca068c70fd80d740afe617fc7b5c52a446a02 on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-866191272
@Lunderberg we can try to ignore these two warnings by updating the lines here https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-854700965
ping @Lunderberg to followup on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-867681841
Thanks @Lunderberg !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-840553210
looks like the correction reveals the doc build errors :) @Lunderberg can you attempt to fix these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-867063664
And updated again, both to fix a few more issues that arose on `main`, and to ignore the warnings coming from `git describe` and `coremltools`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-856132981
One last minor update, removed some debug code in `task_sphinx_precheck.sh`, but kept a deliberate repeat of the warnings at the end of the precheck script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-841418602
Sure, I can take a look at the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg edited a comment on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg edited a comment on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-863554746
@areusch I think I'll need some help on this one, as the remaining warnings relate to the CI image and setup.
* `WARNING:root:git describe: fatal: No names found, cannot describe anything.`
Cannot reproduce in the local docker image. It looks like sphinx is trying to run git describe, but the CI's copy of the repo is too shallow. How deep of a clone does the CI use?
* `WARNING:root:scikit-learn version 0.24.2 is not supported. Minimum required version: 0.17. Maximum required version: 0.19.2. Disabling scikit-learn conversion API.`
From importing `coremltools`. The current version 4.1 has a maximum version of `scikit-learn<=0.19.2`. Unfortunately, the current version of `gluoncv==0.10.1` has a minimum version of `scikit-learn>=0.23.2`, so it won't be a simple update of a single package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-867680223
And it passed! Should be ready to merge, as it has up-to-date fixes for all documentation warnings on the main branch through yesterday afternoon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-855083545
Thanks for the reminder on it! I've fixed about half of the ~80 warnings this afternoon, working my way through the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-863554746
@areusch I think I'll need some help on this one, as the remaining warnings relate to the CI image and setup.
* `WARNING:root:git describe: fatal: No names found, cannot describe anything.`
Cannot reproduce in the local docker image. It looks like sphinx is trying to run git describe, but the CI's copy of the repo is too shallow. How deep of a clone does the CI use?
* `WARNING:root:scikit-learn version 0.24.2 is not supported. Minimum required version: 0.17. Maximum required version: 0.19.2. Disabling scikit-learn conversion API.`
From importing `coremltools`. The current version 4.1 has a maximum version of `scikit-learn<=0.19.2`. Unfortunately, the current version of `gluoncv==0.10.1` has a minimum version of `scikit-learn>=0.23.2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-866244773
Good point, and I agree that these probably aren't warnings that are relevant for the documentation building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-868783175
wow, thanks @Lunderberg for catching this and fixing all the docs bugs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #8029:
URL: https://github.com/apache/tvm/pull/8029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8029: [Docs] Prevented docs/1 file from being generated.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8029:
URL: https://github.com/apache/tvm/pull/8029#issuecomment-856085049
The documentation build now passes without warning when I run it locally, so let's see how it goes on the CI. The most frequent issues were broken links/references, missing line breaks in docstrings before code examples, and ambiguous type references in docstrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org