You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/01/02 07:56:43 UTC
[PR] [improve](function) get result from constant_col when expr is const [doris]
zhangstar333 opened a new pull request, #29403:
URL: https://github.com/apache/doris/pull/29403
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873856114
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876674886
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.79 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17184188406 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877099219
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876694342
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit 54a149b6a7edc9e1affc9e6dc16f3fb2f63ff6c2, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5483 5094 5111 5094
q2 395 160 162 160
q3 1441 1134 1178 1134
q4 1105 786 817 786
q5 3139 3099 3099 3099
q6 226 137 136 136
q7 976 566 519 519
q8 2167 2290 2278 2278
q9 6661 6642 6618 6618
q10 3197 3104 3088 3088
q11 338 226 212 212
q12 381 230 240 230
q13 4402 3617 3651 3617
q14 253 202 214 202
q15 581 535 526 526
q16 455 380 419 380
q17 1048 567 623 567
q18 7096 6756 6778 6756
q19 1641 1518 1548 1518
q20 556 349 332 332
q21 2869 2495 2443 2443
q22 401 332 333 332
Total cold run time: 44811 ms
Total hot run time: 40027 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5167 5079 5051 5051
q2 338 242 244 242
q3 3355 3331 3327 3327
q4 2173 2041 2065 2041
q5 5978 5911 5906 5906
q6 225 128 128 128
q7 2367 1923 1965 1923
q8 3574 3667 3650 3650
q9 9016 8978 8991 8978
q10 3844 3899 3920 3899
q11 579 474 484 474
q12 804 650 633 633
q13 3882 3182 3186 3182
q14 304 280 265 265
q15 593 529 520 520
q16 567 500 508 500
q17 2023 1818 1798 1798
q18 8729 8443 8430 8430
q19 1763 1665 1674 1665
q20 2269 1984 1953 1953
q21 5746 5345 5323 5323
q22 567 564 514 514
Total cold run time: 63863 ms
Total hot run time: 60402 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876649978
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit 54a149b6a7edc9e1affc9e6dc16f3fb2f63ff6c2, data reload: false
------ Round 1 ----------------------------------
q1 18259 7283 5113 5113
q2 2030 153 140 140
q3 10673 1132 1140 1132
q4 10347 793 833 793
q5 7806 3007 2952 2952
q6 219 138 135 135
q7 938 507 545 507
q8 9263 2041 2040 2040
q9 6885 6455 6427 6427
q10 8241 3031 3061 3031
q11 419 210 222 210
q12 395 236 238 236
q13 18004 3616 3655 3616
q14 249 208 207 207
q15 574 524 533 524
q16 458 405 412 405
q17 974 527 495 495
q18 7350 6792 6766 6766
q19 1595 1458 1424 1424
q20 694 343 356 343
q21 2821 2391 2452 2391
q22 378 320 339 320
Total cold run time: 108572 ms
Total hot run time: 39207 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5168 5184 5062 5062
q2 339 230 251 230
q3 3322 3309 3281 3281
q4 2139 1997 2013 1997
q5 5806 5833 5800 5800
q6 214 123 125 123
q7 2303 1932 1898 1898
q8 3395 3465 3483 3465
q9 8884 8807 8744 8744
q10 3783 3855 3852 3852
q11 577 483 498 483
q12 799 625 639 625
q13 6901 3203 3172 3172
q14 282 270 265 265
q15 581 519 526 519
q16 558 493 519 493
q17 1972 1794 1795 1794
q18 8636 8343 8357 8343
q19 1628 1588 1612 1588
q20 2191 1947 1934 1934
q21 5582 5306 5258 5258
q22 550 527 476 476
Total cold run time: 65610 ms
Total hot run time: 59402 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29403:
URL: https://github.com/apache/doris/pull/29403#discussion_r1441755535
##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -554,4 +554,12 @@ Status VExpr::check_constant(const Block& block, ColumnNumbers arguments) const
return Status::OK();
}
+Status VExpr::get_result_from_const(vectorized::Block* block, const std::string& expr_name,
Review Comment:
warning: method 'get_result_from_const' can be made static [readability-convert-member-functions-to-static]
```suggestion
static Status VExpr::get_result_from_const(vectorized::Block* block, const std::string& expr_name,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873735724
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 7dab450ccb5d7c81c838c80df13d0ece96e52d84, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5491 5088 5074 5074
q2 402 172 159 159
q3 1469 1146 1190 1146
q4 1080 879 877 877
q5 3122 3138 3122 3122
q6 228 137 128 128
q7 986 553 527 527
q8 2129 2271 2221 2221
q9 6643 6639 6627 6627
q10 3181 3152 3122 3122
q11 327 222 229 222
q12 380 234 230 230
q13 4415 3660 3644 3644
q14 261 217 221 217
q15 611 544 550 544
q16 449 392 407 392
q17 1025 537 529 529
q18 7060 6709 6761 6709
q19 1626 1516 1397 1397
q20 579 362 331 331
q21 2914 2510 2471 2471
q22 403 308 326 308
Total cold run time: 44781 ms
Total hot run time: 39997 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5132 5007 5016 5007
q2 338 246 251 246
q3 3351 3270 3256 3256
q4 2167 1982 2004 1982
q5 5955 5949 5967 5949
q6 232 126 124 124
q7 2386 1973 1949 1949
q8 3554 3677 3655 3655
q9 9076 8960 9031 8960
q10 3875 3928 3913 3913
q11 578 481 492 481
q12 808 661 664 661
q13 3863 3219 3200 3200
q14 298 256 256 256
q15 608 558 553 553
q16 541 510 532 510
q17 2014 1838 1802 1802
q18 8710 8336 8412 8336
q19 1736 1681 1701 1681
q20 2277 1993 1984 1984
q21 5784 5340 5420 5340
q22 559 487 519 487
Total cold run time: 63842 ms
Total hot run time: 60332 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876681866
TeamCity be ut coverage result:
Function Coverage: 36.63% (8615/23517)
Line Coverage: 28.67% (70015/244187)
Region Coverage: 27.64% (36230/131082)
Branch Coverage: 24.34% (18509/76048)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54a149b6a7edc9e1affc9e6dc16f3fb2f63ff6c2_54a149b6a7edc9e1affc9e6dc16f3fb2f63ff6c2/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873742367
TeamCity be ut coverage result:
Function Coverage: 36.64% (8615/23513)
Line Coverage: 28.69% (70018/244020)
Region Coverage: 27.68% (36246/130939)
Branch Coverage: 24.38% (18519/75972)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7dab450ccb5d7c81c838c80df13d0ece96e52d84_7dab450ccb5d7c81c838c80df13d0ece96e52d84/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873872503
TeamCity be ut coverage result:
Function Coverage: 36.63% (8612/23513)
Line Coverage: 28.68% (69978/244023)
Region Coverage: 27.66% (36221/130940)
Branch Coverage: 24.36% (18509/75972)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a5f9d4712963e182f028a7ab0dafb171382a66e4_a5f9d4712963e182f028a7ab0dafb171382a66e4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #29403:
URL: https://github.com/apache/doris/pull/29403#discussion_r1441643347
##########
be/src/vec/exprs/vin_predicate.cpp:
##########
@@ -94,6 +95,12 @@ void VInPredicate::close(VExprContext* context, FunctionContext::FunctionStateSc
}
Status VInPredicate::execute(VExprContext* context, Block* block, int* result_column_id) {
+ if ((_constant_col != nullptr) && is_constant()) { // const have execute in open function
Review Comment:
use a function to do the same work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877178766
TeamCity be ut coverage result:
Function Coverage: 36.63% (8616/23519)
Line Coverage: 28.67% (70016/244196)
Region Coverage: 27.65% (36239/131082)
Branch Coverage: 24.34% (18509/76048)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3a17a14e2d1e66f1b07f1311be7d34b1ebf8fa0_b3a17a14e2d1e66f1b07f1311be7d34b1ebf8fa0/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876670190
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
```
TPC-DS sf100 test result on commit 54a149b6a7edc9e1affc9e6dc16f3fb2f63ff6c2, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 949 350 333 333
query2 6419 2032 1935 1935
query3 6645 210 205 205
query4 26897 22507 22437 22437
query5 3898 497 501 497
query6 261 174 174 174
query7 4596 261 263 261
query8 233 211 193 193
query9 8278 2521 2552 2521
query10 540 239 227 227
query11 16191 15515 15524 15515
query12 143 74 74 74
query13 1641 310 326 310
query14 11667 7079 7001 7001
query15 222 187 190 187
query16 6314 269 262 262
query17 1872 485 480 480
query18 1924 284 272 272
query19 188 132 135 132
query20 76 72 80 72
query21 186 98 94 94
query22 4977 4864 4774 4774
query23 32327 31193 31262 31193
query24 12049 2837 2826 2826
query25 611 356 328 328
query26 1752 133 139 133
query27 2913 272 269 269
query28 7123 1875 1860 1860
query29 2102 378 388 378
query30 280 144 147 144
query31 1054 778 789 778
query32 84 55 57 55
query33 732 251 247 247
query34 921 441 443 441
query35 895 793 774 774
query36 1261 1220 1168 1168
query37 187 70 69 69
query38 3398 3275 3266 3266
query39 1309 1283 1272 1272
query40 312 85 89 85
query41 37 36 34 34
query42 89 85 83 83
query43 497 472 484 472
query44 1063 683 695 683
query45 194 185 175 175
query46 1077 626 631 626
query47 1707 1601 1516 1516
query48 331 250 253 250
query49 1214 303 311 303
query50 803 350 327 327
query51 5329 5245 5352 5245
query52 89 89 88 88
query53 213 143 144 143
query54 1380 547 566 547
query55 96 90 85 85
query56 203 190 186 186
query57 1042 947 944 944
query58 214 197 192 192
query59 2781 2556 2627 2556
query60 225 220 218 218
query61 87 84 85 84
query62 653 450 460 450
query63 161 149 144 144
query64 5889 1738 1664 1664
query65 3302 3232 3248 3232
query66 1390 342 339 339
query67 15749 15200 15198 15198
query68 12580 512 516 512
query69 496 254 248 248
query70 1724 1483 1522 1483
query71 494 202 204 202
query72 5580 3513 3494 3494
query73 2899 309 310 309
query74 7102 6442 6460 6442
query75 5174 2297 2329 2297
query76 6281 1135 1108 1108
query77 652 245 262 245
query78 9079 8682 8561 8561
query79 1019 499 490 490
query80 546 356 332 332
query81 458 207 210 207
query82 208 98 100 98
query83 162 137 130 130
query84 241 52 54 52
query85 907 275 269 269
query86 393 404 397 397
query87 3538 3383 3366 3366
query88 2993 2232 2237 2232
query89 345 261 255 255
query90 1930 189 184 184
query91 116 89 94 89
query92 55 50 53 50
query93 1484 434 418 418
query94 871 177 173 173
query95 445 409 401 401
query96 615 317 310 310
query97 4286 4188 4176 4176
query98 207 202 189 189
query99 1069 829 854 829
Total cold run time: 293191 ms
Total hot run time: 178574 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873850793
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1878061807
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876596700
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873711924
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877175529
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit b3a17a14e2d1e66f1b07f1311be7d34b1ebf8fa0, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5492 5149 5078 5078
q2 386 168 156 156
q3 1457 1172 1146 1146
q4 1067 799 826 799
q5 3117 3104 3148 3104
q6 224 135 136 135
q7 963 542 514 514
q8 2154 2208 2286 2208
q9 6691 6660 6652 6652
q10 3162 3118 3133 3118
q11 341 233 234 233
q12 374 231 228 228
q13 4421 3659 3657 3657
q14 255 216 210 210
q15 582 536 532 532
q16 452 404 397 397
q17 1041 484 515 484
q18 7111 6748 6901 6748
q19 1637 1482 1406 1406
q20 617 344 385 344
q21 2820 2551 2493 2493
q22 402 348 330 330
Total cold run time: 44766 ms
Total hot run time: 39972 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5061 5064 4981 4981
q2 338 238 228 228
q3 3403 3354 3333 3333
q4 2170 2023 2002 2002
q5 5956 5956 5911 5911
q6 224 126 131 126
q7 2408 1934 1913 1913
q8 3559 3692 3670 3670
q9 8998 9011 8952 8952
q10 3865 3904 3909 3904
q11 565 472 479 472
q12 806 640 627 627
q13 3908 3175 3190 3175
q14 298 285 288 285
q15 593 525 527 525
q16 590 525 476 476
q17 2049 1859 1792 1792
q18 8731 8363 8326 8326
q19 1748 1711 1707 1707
q20 2239 1979 1976 1976
q21 5660 5244 5321 5244
q22 568 511 508 508
Total cold run time: 63737 ms
Total hot run time: 60133 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1878061833
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873890090
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit a5f9d4712963e182f028a7ab0dafb171382a66e4, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5523 5139 5218 5139
q2 385 167 148 148
q3 1458 1155 1138 1138
q4 1080 855 817 817
q5 3135 3014 3126 3014
q6 223 143 128 128
q7 972 565 520 520
q8 2145 2240 2241 2240
q9 6705 6647 6654 6647
q10 3179 3162 3147 3147
q11 332 231 226 226
q12 388 226 232 226
q13 4396 3624 3669 3624
q14 262 215 218 215
q15 595 550 550 550
q16 445 394 389 389
q17 1046 609 537 537
q18 7104 6769 6838 6769
q19 1646 1554 1468 1468
q20 580 421 361 361
q21 2896 2445 2496 2445
q22 409 328 320 320
Total cold run time: 44904 ms
Total hot run time: 40068 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5091 5137 5136 5136
q2 347 239 251 239
q3 3375 3320 3287 3287
q4 2150 2007 1992 1992
q5 5939 5890 5911 5890
q6 226 129 120 120
q7 2405 1922 1961 1922
q8 3545 3661 3670 3661
q9 9001 9005 8947 8947
q10 3890 3914 3942 3914
q11 585 479 474 474
q12 801 637 667 637
q13 3870 3199 3210 3199
q14 294 272 254 254
q15 605 539 531 531
q16 554 511 549 511
q17 2031 1805 1815 1805
q18 8786 8263 8331 8263
q19 1753 1718 1679 1679
q20 2276 1994 2002 1994
q21 5672 5226 5277 5226
q22 576 524 543 524
Total cold run time: 63772 ms
Total hot run time: 60205 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873746273
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.77 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17183891916 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873898617
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.23 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.1 seconds inserted 10000000 Rows, about 355K ops/s
storage size: 17183905511 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877180260
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
```
TPC-DS sf100 test result on commit b3a17a14e2d1e66f1b07f1311be7d34b1ebf8fa0, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 929 346 330 330
query2 6415 2045 1886 1886
query3 6642 212 208 208
query4 25920 22467 22439 22439
query5 3881 516 528 516
query6 273 180 174 174
query7 4591 268 266 266
query8 230 196 204 196
query9 8198 2566 2575 2566
query10 426 255 229 229
query11 16237 15531 15800 15531
query12 138 76 72 72
query13 1752 330 322 322
query14 12929 7106 7035 7035
query15 210 184 189 184
query16 6344 271 260 260
query17 1890 491 482 482
query18 1951 273 267 267
query19 190 136 134 134
query20 78 72 75 72
query21 184 100 96 96
query22 4779 4863 4662 4662
query23 32293 31237 31239 31237
query24 11605 2839 2783 2783
query25 594 341 327 327
query26 1761 145 140 140
query27 2850 267 274 267
query28 7104 1881 1877 1877
query29 2099 375 384 375
query30 290 149 146 146
query31 992 782 777 777
query32 93 58 54 54
query33 743 266 267 266
query34 933 457 446 446
query35 886 712 763 712
query36 1276 1156 1186 1156
query37 188 66 64 64
query38 3419 3255 3258 3255
query39 1324 1298 1307 1298
query40 303 87 86 86
query41 38 37 35 35
query42 91 80 82 80
query43 536 510 502 502
query44 1094 695 713 695
query45 196 191 187 187
query46 1057 648 664 648
query47 1687 1519 1580 1519
query48 330 265 259 259
query49 1217 315 309 309
query50 720 334 372 334
query51 5423 5367 5437 5367
query52 95 83 76 76
query53 206 145 147 145
query54 1339 570 591 570
query55 95 78 79 78
query56 181 190 187 187
query57 1067 959 971 959
query58 226 196 193 193
query59 2741 2684 2525 2525
query60 242 222 227 222
query61 85 81 80 80
query62 700 481 478 478
query63 161 147 147 147
query64 5782 1664 1704 1664
query65 3325 3234 3260 3234
query66 1386 340 357 340
query67 15736 15206 15436 15206
query68 12741 511 509 509
query69 514 237 253 237
query70 1736 1556 1474 1474
query71 494 220 211 211
query72 5610 3524 3496 3496
query73 3078 327 309 309
query74 7059 6511 6558 6511
query75 5272 2284 2271 2271
query76 6318 1125 1109 1109
query77 666 262 294 262
query78 9141 8584 8727 8584
query79 1070 509 515 509
query80 602 345 341 341
query81 464 207 210 207
query82 206 97 88 88
query83 187 138 135 135
query84 247 54 51 51
query85 951 268 258 258
query86 382 398 392 392
query87 3617 3337 3385 3337
query88 3022 2277 2274 2274
query89 337 265 258 258
query90 1948 200 203 200
query91 117 88 88 88
query92 59 52 49 49
query93 1776 485 493 485
query94 852 186 175 175
query95 460 414 414 414
query96 641 323 316 316
query97 4306 4152 4206 4152
query98 224 202 191 191
query99 1091 834 866 834
Total cold run time: 293884 ms
Total hot run time: 178959 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877184503
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.93 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.9 seconds inserted 10000000 Rows, about 358K ops/s
storage size: 17183887964 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1876583174
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1873707200
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #29403:
URL: https://github.com/apache/doris/pull/29403#discussion_r1442435077
##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -554,4 +554,12 @@ Status VExpr::check_constant(const Block& block, ColumnNumbers arguments) const
return Status::OK();
}
+Status VExpr::get_result_from_const(vectorized::Block* block, const std::string& expr_name,
Review Comment:
void do nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #29403:
URL: https://github.com/apache/doris/pull/29403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) get result from constant_col when expr is const [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29403:
URL: https://github.com/apache/doris/pull/29403#issuecomment-1877158991
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit b3a17a14e2d1e66f1b07f1311be7d34b1ebf8fa0, data reload: false
------ Round 1 ----------------------------------
q1 18281 5209 5152 5152
q2 2018 156 146 146
q3 10618 1111 1088 1088
q4 10265 812 807 807
q5 7817 2987 2955 2955
q6 223 132 133 132
q7 949 532 533 532
q8 9321 2086 2017 2017
q9 6890 6471 6413 6413
q10 8288 3064 3054 3054
q11 427 227 218 218
q12 389 234 234 234
q13 18008 3653 3663 3653
q14 245 223 207 207
q15 580 521 513 513
q16 455 396 402 396
q17 967 477 477 477
q18 7524 6793 6782 6782
q19 1610 1445 1362 1362
q20 690 328 327 327
q21 2889 2362 2450 2362
q22 386 313 325 313
Total cold run time: 108840 ms
Total hot run time: 39140 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5055 5099 5163 5099
q2 342 234 234 234
q3 3335 3316 3291 3291
q4 2136 2036 2023 2023
q5 5833 5815 5835 5815
q6 214 124 126 124
q7 2364 1945 1928 1928
q8 3401 3489 3479 3479
q9 8865 8794 8787 8787
q10 3833 3879 3860 3860
q11 586 478 496 478
q12 803 643 642 642
q13 7101 3198 3219 3198
q14 301 280 271 271
q15 584 534 517 517
q16 566 502 507 502
q17 1929 1810 1772 1772
q18 8718 8438 8322 8322
q19 1636 1619 1591 1591
q20 2203 1977 1950 1950
q21 5617 5216 5370 5216
q22 541 473 485 473
Total cold run time: 65963 ms
Total hot run time: 59572 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org