You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2025/09/24 08:13:47 UTC
[PR] GH-47633: [Dev][Integration] Write all files with `--write_generated_json` [arrow]
pitrou opened a new pull request, #47634:
URL: https://github.com/apache/arrow/pull/47634
### Rationale for this change
The `--write_generated_json` option to `archery integration` was originally a JS-specific hack, but its usage was removed from the JS codebase in commit [c65bcda60b899649c3daf6f16ff5c4e12a41f06d](https://github.com/apache/arrow-js/commit/c65bcda60b899649c3daf6f16ff5c4e12a41f06d).
### What changes are included in this PR?
Rework this option to write all generated JSON integration files, not a subset of them.
Also fix the option's spelling to use hyphens not underscores.
### Are these changes tested?
Only manually.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47633: [Dev][Integration] Write all files with `--write_generated_json` [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47634:
URL: https://github.com/apache/arrow/pull/47634#discussion_r2375653990
##########
dev/archery/archery/cli.py:
##########
@@ -773,7 +774,8 @@ def integration(with_all=False, random_seed=12345, **args):
"""
- from .integration.runner import write_js_test_json, run_all_tests
Review Comment:
Oh, I see you removed it from arrow-js in https://github.com/apache/arrow-js/pull/148. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47633: [Dev][Integration] Write all files with `--write_generated_json` [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47634:
URL: https://github.com/apache/arrow/pull/47634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47633: [Dev][Integration] Write all files with `--write_generated_json` [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47634:
URL: https://github.com/apache/arrow/pull/47634#issuecomment-3327206059
@kou @raulcd Does this look ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47633: [Dev][Integration] Write all files with `--write_generated_json` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47634:
URL: https://github.com/apache/arrow/pull/47634#discussion_r2375630990
##########
dev/archery/archery/cli.py:
##########
@@ -773,7 +774,8 @@ def integration(with_all=False, random_seed=12345, **args):
"""
- from .integration.runner import write_js_test_json, run_all_tests
Review Comment:
Can we remove the `write_js_test_json` definition from `.integration.runner`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org