You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Michael Sokolov (Jira)" <ji...@apache.org> on 2019/12/18 13:46:00 UTC
[jira] [Resolved] (LUCENE-8489) Provide List type constructors for
BaseCompositeReader based Readers
[ https://issues.apache.org/jira/browse/LUCENE-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Sokolov resolved LUCENE-8489.
-------------------------------------
Resolution: Won't Fix
The discussion ended up deciding not to go forward , so I'm resolving the issue.
> Provide List type constructors for BaseCompositeReader based Readers
> --------------------------------------------------------------------
>
> Key: LUCENE-8489
> URL: https://issues.apache.org/jira/browse/LUCENE-8489
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Namgyu Kim
> Priority: Major
> Labels: usability
> Attachments: LUCENE-8489.patch
>
>
> Currently, Reader based on BaseCompositeReader(MultiReader, ParallelCompositeReader, DirectoryReader) does not support List type constructor.
> In fact, this does not make a big difference in performance, but users will think positively if the API supports more variants.
> I will add the following to support this.
> 1) MultiReader
> {code:java}
> public MultiReader(List<IndexReader> subReaders) throws IOException {
> this(subReaders, true);
> }
> public MultiReader(List<IndexReader> subReaders, boolean closeSubReaders) throws IOException {
> this(subReaders.toArray(new IndexReader[0]), closeSubReaders);
> }
> {code}
> 2) ParallelCompositeReader
> {code:java}
> public ParallelCompositeReader(List<CompositeReader> readers) throws IOException {
> this(true, readers);
> }
> public ParallelCompositeReader(boolean closeSubReaders, List<CompositeReader> readers) throws IOException {
> this(closeSubReaders, readers, readers);
> }
> public ParallelCompositeReader(boolean closeSubReaders, List<CompositeReader> readers, List<CompositeReader> storedFieldReaders) throws IOException {
> this(closeSubReaders, readers.toArray(new CompositeReader[0]), storedFieldReaders.toArray(new CompositeReader[0]));
> }
> {code}
> 3) DirectoryReader
> {code:java}
> protected DirectoryReader(Directory directory, List<LeafReader> segmentReaders) throws IOException {
> super(segmentReaders);
> this.directory = directory;
> }
> {code}
> 4) BaseCompositeReader
> {code:java}
> @SuppressWarnings("unchecked")
> protected BaseCompositeReader(List<R> subReaders) throws IOException {
> this(subReaders.toArray((R[]) new IndexReader[subReaders.size()]));
> }
> {code}
> 5) Test
> I wrote a test case in "TestParallelCompositeReader".
> If you have any questions or requests, please left any comments :D
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org