You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/03 11:33:42 UTC
[GitHub] flink pull request #4069: [FLINK-6723] Activate strict checkstyle for flink-...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4069
[FLINK-6723] Activate strict checkstyle for flink-libraries
Move checkstyle plugin into flink-libraries pom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6723
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4069.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4069
----
commit 87ddb49f1b7f1870ab442e0ba70b3acee724794f
Author: zentol <ch...@apache.org>
Date: 2017-06-03T11:31:33Z
[FLINK-6723] Activate strict checkstyle for flink-libraries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4069
+1
Are the tests failing for lack of the fix reordering the pom in `flink-dist`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4069: [FLINK-6723] Activate strict checkstyle for flink-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4069
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4069
@greghogan I think the failing tests for this is due to https://issues.apache.org/jira/browse/FLINK-6836 (a different issue from the pom ordering fix).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4069
Thanks @tzulitai.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4069
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---