You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 16:50:31 UTC

[GitHub] [arrow] alamb commented on a change in pull request #8698: ARROW-10636: [Rust][Parquet] Remove rust specialization

alamb commented on a change in pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#discussion_r535404259



##########
File path: rust/parquet/src/encodings/encoding.rs
##########
@@ -130,6 +130,7 @@ impl<T: DataType> PlainEncoder<T> {
 }
 
 impl<T: DataType> Encoder<T> for PlainEncoder<T> {
+    #[cold]

Review comment:
       that might be helpful context to add as a comment in the source code so it outlasts this PR review




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org