You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/07/01 21:21:11 UTC

[kudu-CR] docs: add info about Sentry

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13759 )

Change subject: docs: add info about Sentry
......................................................................


Patch Set 4:

(6 comments)

LGTM, thanks a lot for documenting it! Though it would be good to call out disabling web UI as we discussed offline. +1 to let Alexey to review it as well.

http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc
File docs/security.adoc:

http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@199
PS2, Line 199: details about Sentry 
> I already called out 2.2 elsewhere. I prefer this being generic and not tie
LGTM, thanks for the update!


http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@219
PS2, Line 219: matically attach authorizat
> This is noted in the Caching section.
Ack


http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@228
PS2, Line 228:  a tablet server that has been configured to enforce fine-grained access
             : 
> That seems like it should be documented in the HMS docs, no? That doesn't h
Hmm, yeah, makes sense after thinking again.


http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@272
PS2, Line 272: d extra
> I don't think so, if questions come up about it, they can ask on mailing li
Ack


http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@301
PS2, Line 301: 
> I would choose either "with no rename" or "without a rename"; I'm leaving t
Ack


http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc@321
PS2, Line 321: === Policy for Kudu Tablet Servers
> I've pointed at Impala authorization docs elsewhere. Is that not sufficient
Yeah, the note you added sounds good enough.



-- 
To view, visit http://gerrit.cloudera.org:8080/13759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50bb11a9a5d2d2294cf0ac34ccd7d75aa2cbcdf
Gerrit-Change-Number: 13759
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:21:11 +0000
Gerrit-HasComments: Yes