You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Dmitry Karachentsev <dk...@gridgain.com> on 2018/06/29 14:06:15 UTC

Review IGNITE-8859

Hi guys,

I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please 
review.

I'm not sure if there exist tests, but I tested on Windows/Linux for 
1.7, 1.8, 9 and 10 JDKs manually.

Thanks!

Re: Review IGNITE-8859

Posted by Petr Ivanov <mr...@gmail.com>.
Very nice!


I’ll try to review changes at weekend.


> On 29 Jun 2018, at 17:40, Dmitry Karachentsev <dk...@gridgain.com> wrote:
> 
> Hi Petr,
> 
> Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
> In waring showed JAVA_HOME directory. If it would be useful, I can add detected version.
> 
> Thanks!
> 
> 29.06.2018 17:34, Petr Ivanov пишет:
>> Looks good.
>> 
>> Did you intentionally not mentioned JDK10 in warning/error texts?
>> Also have you tested running built Apache Ignite under JDK10?
>> 
>> 
>>> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <dk...@gridgain.com> wrote:
>>> 
>>> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
>>> 
>>> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>>>> Hi guys,
>>>> 
>>>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>>>> 
>>>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>>>> 
>>>> Thanks!
>>>> 
>

Re: Review IGNITE-8859

Posted by Dmitry Karachentsev <dk...@gridgain.com>.
Hi Petr,

Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
In waring showed JAVA_HOME directory. If it would be useful, I can add 
detected version.

Thanks!

29.06.2018 17:34, Petr Ivanov пишет:
> Looks good.
>
> Did you intentionally not mentioned JDK10 in warning/error texts?
> Also have you tested running built Apache Ignite under JDK10?
>
>
>> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <dk...@gridgain.com> wrote:
>>
>> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
>>
>> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>>> Hi guys,
>>>
>>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>>>
>>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>>>
>>> Thanks!
>>>

Re: Review IGNITE-8859

Posted by Petr Ivanov <mr...@gmail.com>.
Looks good.

Did you intentionally not mentioned JDK10 in warning/error texts?
Also have you tested running built Apache Ignite under JDK10?


> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <dk...@gridgain.com> wrote:
> 
> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
> 
> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>> Hi guys,
>> 
>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>> 
>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>> 
>> Thanks!
>> 
>

Re: Review IGNITE-8859

Posted by Dmitry Karachentsev <dk...@gridgain.com>.
Forgot a link to the ticket 
https://issues.apache.org/jira/browse/IGNITE-8859

29.06.2018 17:06, Dmitry Karachentsev пишет:
> Hi guys,
>
> I've enhanced our scripts a bit to allow run Ignite on Java 10+. 
> Please review.
>
> I'm not sure if there exist tests, but I tested on Windows/Linux for 
> 1.7, 1.8, 9 and 10 JDKs manually.
>
> Thanks!
>