You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2020/12/07 09:27:22 UTC

[GitHub] [struts] Yilinwang commented on a change in pull request #455: sort getMethods for deterministic iteration order

Yilinwang commented on a change in pull request #455:
URL: https://github.com/apache/struts/pull/455#discussion_r537349825



##########
File path: plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java
##########
@@ -410,7 +411,9 @@ else if (serializationParams.getErrorCode() > 0)
     public static Method[] listSMDMethods(Class clazz, boolean ignoreInterfaces) {
         final List<Method> methods = new LinkedList<>();
         if (ignoreInterfaces) {
-            for (Method method : clazz.getMethods()) {
+            Method[] SMDMethods = clazz.getMethods();

Review comment:
       I think methods is used at 412 `final List<Method> methods = new LinkedList<>();`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org