You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/16 19:35:01 UTC
[GitHub] [airflow] jmaldon1 opened a new issue #17055: set_extra isn't working as expected.
jmaldon1 opened a new issue #17055:
URL: https://github.com/apache/airflow/issues/17055
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: v2.1.0
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release): Macos
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
<!-- (please include exact error messages if you can) -->
Basically, I want the ability to override the `extras` in a connection object.
Using the `set_extra` method in the `conn` object will set the extra, but it will doesn't seem to use it when running `hook.run()`
**What you expected to happen**:
`hook.run()` should be using the new `extra` value.
<!-- What do you think went wrong? -->
**How to reproduce it**:
```python
# Export this connection elsewhere, comment out the extra because I want to set it programmatically somewhere else.
Connection(
conn_id="demo_mssql_odbc",
conn_type="odbc",
login=user,
schema=database,
password=password,
host=f"{host},{port}",
# extra=json.dump({
# "Driver": "ODBC Driver 17 for SQL Server"
# })
)
conn = MsSqlHook.get_connection(conn_id=self.mssql_conn_id)
conn.set_extra(json.dump({"Driver": "ODBC Driver 17 for SQL Server"}))
print(conn.get_extra())
# {"Driver": "ODBC Driver 17 for SQL Server"}
hook = conn.get_hook()
hook.run()
# ERROR
# pyodbc.InterfaceError: ('IM002', '[IM002] [unixODBC][Driver Manager]Data source name not found and no default driver specified (0) (SQLDriverConnect)')
# ^ this error occurs when pyodbc cannot find the Driver which gets set in the `extras`
```
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #17055: set_extra isn't working as expected.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17055:
URL: https://github.com/apache/airflow/issues/17055#issuecomment-881673083
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #17055: `conn.set_extra` isn't working as expected.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17055:
URL: https://github.com/apache/airflow/issues/17055#issuecomment-882081645
It does not work this way. get_hook() method is implemented by instantiating new hook class and passes connection id as parameter - which in turn will create a new connection class using standard mechanisms (from db or from variable).
Connections should be immutable in your tasks. You should not attempt to dynamically modify them. You can always create a new connection with different id and different extra and use this other id. In some methods/objects connections are cached and in some they are recreated and trying to modify them on the flight is a bad idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #17055: `conn.set_extra` isn't working as expected.
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #17055:
URL: https://github.com/apache/airflow/issues/17055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org