[GitHub] nwangtw commented on a change in pull request #3032: Nwang/add spout based source streamlet

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3032: Nwang/add spout based source streamlet
URL: https://github.com/apache/incubator-heron/pull/3032#discussion_r230513180
 
 

 ##########
 File path: heron/api/tests/scala/org/apache/heron/streamlet/scala/impl/BuilderImplTest.scala
 ##########
 @@ -69,4 +71,16 @@ class BuilderImplTest extends BaseFunSuite {
     override def cleanup(): Unit = numbers.clear()
   }
 
+  test(
+    "BuilderImpl should support streamlet generation from a user defined spout") {
+    val spout = new TestSpout
+    val generatorStreamletObj = Builder.newBuilder
+      .newSource(spout)
+      .setName("Generator_Streamlet_1")
 
 Review comment:
   True. Better to be more explicit. Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services