You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "a2833986889 (GitHub)" <gi...@apache.org> on 2018/10/29 04:40:47 UTC

[GitHub] [incubator-dubbo] a2833986889 opened pull request #2699: dubbo Add a new serialization -gson

## What is the purpose of the change


dubbo Add a new serialization -gson

## Brief changelog

dubbo Add a new serialization -gson

## Verifying this change

dubbo Add a new serialization -gson

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] kimmking commented on pull request #2699: dubbo Add a new serialization -gson

Posted by "kimmking (GitHub)" <gi...@apache.org>.
remove author info

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] beiwei30 commented on issue #2699: dubbo Add a new serialization -gson

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@a2833986889 I have moved your imp into https://github.com/dubbo/dubbo-serialization-gson. Let me know if you want to continue to work on this project, I can add you into dubbo group.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] kimmking commented on pull request #2699: dubbo Add a new serialization -gson

Posted by "kimmking (GitHub)" <gi...@apache.org>.
remove blank lines

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] beiwei30 closed pull request #2699: dubbo Add a new serialization -gson

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org