[jira] Commented: (DERBY-648) ij 'show connections' statement does not work in JSR169

["Kathey Marsden (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-648?page=comments#action_12356031 ] 

Kathey Marsden commented on DERBY-648:
--------------------------------------

This change looks good except that there seems to be a formatting issue with the new code in the ij.jj file.  Could you fix that up and I'll commit.
                      row.append('*');
                      haveCurrent=true;
                   }
-                  row.append(" -       ");
-                  row.append(s.getConnection().getMetaData().getURL());
+
+                         //If ij.dataSource property is set, show only connection names.
+                         //In this case, URL is not used to get connection, so do not append URL
+                         String dsName = util.getSystemProperty("ij.dataSource");
+                                 if(dsName == null){
+                         row.append(" -        ");
+                     row.append(s.getConnection().getMetaData().getURL());
+                 }
                   // save the warnings from these connections
                   w = appendWarnings(w,s.getConnection().getWarnings());
                   s.getConnection().clearWarnings();



> ij 'show connections' statement does not work in JSR169
> -------------------------------------------------------
>
>          Key: DERBY-648
>          URL: http://issues.apache.org/jira/browse/DERBY-648
>      Project: Derby
>         Type: Improvement
>   Components: Tools
>     Versions: 10.2.0.0
>  Environment: J2ME/CDC/Foundation Profile with JSR169
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>     Priority: Minor
>  Attachments: derby-648.diff, derby-648.status
>
> 'show connections' statement throws the following exception when run in CDC/FP with JSR169: "JAVA ERROR: java.lang.NoSuchMethodError: java/sql/DatabaseMetaData.getURL()Ljava/lang/String;"
> This is because java/sql/DatabaseMetaData.getURL() method is not available in JSR169. In JSR169, DataSource has to be used to get a connection and this does not use a URL. So this method is not available.
> Currently, 'show connections' displays connection names along with the URLs used to get the connections. When DataSource is used to get connection (ij.dataSource property is set), I plan to change this to display only connection names. With this change, around 7 tests can be enabled to run in CDC/FP.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira