You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/22 06:51:25 UTC
[GitHub] [fineract] nemux opened a new pull request #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…
nemux opened a new pull request #780:
URL: https://github.com/apache/fineract/pull/780
Some keywords escaped from `grouping` are missing at https://github.com/apache/fineract/pull/757.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nemux commented on issue #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…
Posted by GitBox <gi...@apache.org>.
nemux commented on issue #780:
URL: https://github.com/apache/fineract/pull/780#issuecomment-617941610
> Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?
Yes @vorburger , according to the MySQL reference manual GROUPING become a reserved word in 8.0.1 https://dev.mysql.com/doc/refman/8.0/en/keywords.html
Let me make a test in a previous MySQL version using GROUPING quoted, but according to the documentation should be allowed quoted or not because in previous versions is not a reserved word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on issue #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #780:
URL: https://github.com/apache/fineract/pull/780#issuecomment-617843413
Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nemux edited a comment on issue #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…
Posted by GitBox <gi...@apache.org>.
nemux edited a comment on issue #780:
URL: https://github.com/apache/fineract/pull/780#issuecomment-617941610
> Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?
Yes @vorburger , according to the MySQL reference manual GROUPING became a reserved word in 8.0.1 https://dev.mysql.com/doc/refman/8.0/en/keywords.html
Let me make a test in a previous MySQL version using GROUPING quoted, but according to the documentation should be allowed quoted or not because in previous versions is not a reserved word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nemux commented on issue #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…
Posted by GitBox <gi...@apache.org>.
nemux commented on issue #780:
URL: https://github.com/apache/fineract/pull/780#issuecomment-617952615
And I think we are going to have problems in Travis CI with that switch because the current version of Drizzle. The code itself do not support the new version because little changes:
The @@tx_isolation was renamed in 8.0+ to @@transaction_isolation and this need to be changed in Drizzle to work https://github.com/krummas/DrizzleJDBC/pull/48/commits/ccd8a2c5cd1b34c822744f0fbf276671d413e925 unfortunately as you saw, the project looks dead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org