You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sam Tunnicliffe (JIRA)" <ji...@apache.org> on 2018/12/04 10:37:00 UTC

[jira] [Assigned] (CASSANDRA-14920) Some comparisons used for verifying paging queries in dtests only test the column names and not values

     [ https://issues.apache.org/jira/browse/CASSANDRA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Tunnicliffe reassigned CASSANDRA-14920:
-------------------------------------------

    Assignee: Sam Tunnicliffe

> Some comparisons used for verifying paging queries in dtests only test the column names and not values
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14920
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14920
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Major
>
> The implementation of {{PageAssertionMixin::assertEqualIgnoreOrder}} introduced in CASSANDRA-14134 can't be used to compare expected and actual results when the row data is represented by a {{dict}}. The underlying {{list_to_hashed_dict}} function expected lists of values and when it encounters a dict, it constructs its normalized list using only the keys. So the actual result values may be completely wrong, but as long as the field names are the same the equality check will pass. This affects only {{paging_tests.py}} and {{upgrade_tests/paging_test.py}}, and looks like it maybe a leftover from an earlier dev iteration, as some tests in the affected fixtures are already using the alternative (and correct) {{assertions.py::assert_lists_equal_ignoring_order}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org