You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 12:52:40 UTC

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #747: MINIFICPP-1036 - libarchive extension improvements

bakaid commented on a change in pull request #747: MINIFICPP-1036 - libarchive extension improvements
URL: https://github.com/apache/nifi-minifi-cpp/pull/747#discussion_r401590545
 
 

 ##########
 File path: thirdparty/liblzma/liblzma.patch
 ##########
 @@ -0,0 +1,118 @@
+diff -rupN orig/CMakeLists.txt patched/CMakeLists.txt
+--- orig/CMakeLists.txt	1970-01-01 01:00:00.000000000 +0100
++++ patched/CMakeLists.txt	2020-03-31 21:52:39.000000000 +0200
+@@ -0,0 +1,114 @@
++cmake_minimum_required(VERSION 3.7)
++
++project(liblzma)
++
++set(SOURCES src/common/tuklib_cpucores.c
 
 Review comment:
   We can't run the configure script on Windows, and the only thing lzma provides for Windows are msbuild files which do not integrate well into our CMake build system, so I wrote a windows-specific CMakeLists.txt for the project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services