You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2019/06/25 18:17:00 UTC
[jira] [Comment Edited] (CALCITE-3146) Support the detection of
nested aggregations for JdbcAggregate in SqlImplementor.
[ https://issues.apache.org/jira/browse/CALCITE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872587#comment-16872587 ]
Julian Hyde edited comment on CALCITE-3146 at 6/25/19 6:16 PM:
---------------------------------------------------------------
I saw [~vladimirsitnikov]'s comment that there should be tests. I disagree; it is difficult to write tests to this change, and if the code had been written this way initially no one would have demanded for a test for a sub-type of Aggregate that is not LogicalAggregate.
+1
was (Author: julianhyde):
I saw [~vladimirsitnikov]'s comment that there should be tests. I disagree; it is difficult to write tests to this change, and if the code had been written this way initially no one would have demanded for a test for a sub-type of Aggregate that is not LogicalAggregate.
> Support the detection of nested aggregations for JdbcAggregate in SqlImplementor.
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-3146
> URL: https://issues.apache.org/jira/browse/CALCITE-3146
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: TANG Wen-hui
> Assignee: TANG Wen-hui
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The detection of nested aggregations in SqlImplementor.java is only for
> LogicalAggregate:
>
> {code:java}
> if (rel instanceof LogicalAggregate
> && !dialect.supportsNestedAggregations()
> && hasNestedAggregations((LogicalAggregate) rel)) {
> needNew = true;
> }
> {code}
> It should also support other sub-class of Aggregate such as JdbcAggregate .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)