You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/10 09:22:01 UTC
[GitHub] [airflow] phill84 opened a new pull request #9207: fix kill signal on python3
phill84 opened a new pull request #9207:
URL: https://github.com/apache/airflow/pull/9207
Solves the issue #9202
**File changed**: ``airflow/utils/process_utils.py``
**Problem**
Since python3.5, signals have become ``IntEnum`` instead of ``int``, therefore ``str(signal.SIGTERM)`` yields the string literal ``signal.SIGTERM`` instead of ``15``.
**Solution**
convert ``signal.SIGTERM`` to ``int`` first and then ``str``
- [x] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions. ``unnecessary``
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9207: fix kill signal on python3
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9207:
URL: https://github.com/apache/airflow/pull/9207#issuecomment-641871773
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9207: Improved compatibility with Python 3.5+ - Convert signal.SIGTERM to int
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9207:
URL: https://github.com/apache/airflow/pull/9207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9207: Improved compatibility with Python 3.5+ - Convert signal.SIGTERM to int
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9207:
URL: https://github.com/apache/airflow/pull/9207#issuecomment-641907297
@phill84 I'm glad you decided to contribute to this project. What are your plans? Anything else you would like to improve in the project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] phill84 commented on pull request #9207: Improved compatibility with Python 3.5+ - Convert signal.SIGTERM to int
Posted by GitBox <gi...@apache.org>.
phill84 commented on pull request #9207:
URL: https://github.com/apache/airflow/pull/9207#issuecomment-641913952
@mik-laj Thanks for helping get this fix merged! I am usually a couple minors behind the latest release, so this is actually the first bug I found that hasn't been fixed in master. Let's hope that I won't open new PR's too soon or often, at least for time being. ๐ธ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9207: Improved compatibility with Python 3.5+ - Convert signal.SIGTERM to int
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9207:
URL: https://github.com/apache/airflow/pull/9207#issuecomment-641906429
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org