You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/22 04:05:59 UTC

[GitHub] [spark] HeartSaVioR opened a new pull request, #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments

HeartSaVioR opened a new pull request, #37964:
URL: https://github.com/apache/spark/pull/37964

   ### What changes were proposed in this pull request?
   
   This PR addresses the review comments from the last round of review from @HyukjinKwon  in #37893.
   
   ### Why are the changes needed?
   
   Better documentation and removing unnecessary code.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Slight documentation change.
   
   ### How was this patch tested?
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37964:
URL: https://github.com/apache/spark/pull/37964#discussion_r977211125


##########
python/pyspark/sql/pandas/group_ops.py:
##########
@@ -257,10 +257,10 @@ def applyInPandasWithState(
         user-defined state. The value of the state will be presented as a tuple, as well as the
         update should be performed with the tuple. The corresponding Python types for
         :class:DataType are supported. Please refer to the page
-        https://spark.apache.org/docs/latest/sql-ref-datatypes.html (python tab).
+        https://spark.apache.org/docs/latest/sql-ref-datatypes.html (Python tab).
 
-        The size of each DataFrame in both the input and output can be arbitrary. The number of
-        DataFrames in both the input and output can also be arbitrary.
+        The size of each `pandas.DataFrame` in both the input and output can be arbitrary. The
+        number `pandas.DataFrame` in both the input and output can also be arbitrary.

Review Comment:
   `number` -> `number of`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #37964:
URL: https://github.com/apache/spark/pull/37964#issuecomment-1254495026

   cc. @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR closed pull request #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments

Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments
URL: https://github.com/apache/spark/pull/37964


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #37964: [SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #37964:
URL: https://github.com/apache/spark/pull/37964#issuecomment-1254788965

   Thanks! Merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org