[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1983: CASSANDRA-17964 4.0 ant

[GitBox <gi...@apache.org>]

smiklosovic commented on code in PR #1983:
URL: https://github.com/apache/cassandra/pull/1983#discussion_r1015648508


##########
test/unit/org/apache/cassandra/cql3/validation/operations/CompactStorageTest.java:
##########
@@ -4369,19 +4368,9 @@ private void testUpdate(boolean forceFlush) throws Throwable
         execute("UPDATE %s SET value = ? WHERE partitionKey = ? AND clustering_1 = ?", null, 0, 0);
         flush(forceFlush);
 
-        if (isEmpty(compactOption))

Review Comment:
   I believe this was completely wrong because `isEmpty` was used from `org.reflections` and this started to fail to compile because that lib was updated and that method is not there anymore. But that `if` condition does not make sense as it was done originally because it tests `compactOption` which is `private final static` `String`. Hence, only `else` branch makes sense.
   
   Utils.isEmpty method does internally this:
   
   ````
       public static boolean isEmpty(String s) {
           return s == null || s.length() == 0;
       }
   ````
   
   Hence it always returned false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org