You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "dhruba borthakur (Created) (JIRA)" <ji...@apache.org> on 2011/10/25 02:28:32 UTC
[jira] [Created] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Put attributes are not exposed via the ThriftServer
---------------------------------------------------
Key: HBASE-4658
URL: https://issues.apache.org/jira/browse/HBASE-4658
Project: HBase
Issue Type: Bug
Components: thrift
Reporter: dhruba borthakur
Assignee: dhruba borthakur
The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460259#comment-13460259 ]
Hudson commented on HBASE-4658:
-------------------------------
Integrated in HBase-TRUNK #3363 (See [https://builds.apache.org/job/HBase-TRUNK/3363/])
HBASE-6806 HBASE-4658 breaks backward compatibility / example scripts (Revision 1388318)
Result = FAILURE
stack :
Files :
* /hbase/trunk/examples/thrift/DemoClient.cpp
* /hbase/trunk/examples/thrift/DemoClient.java
* /hbase/trunk/examples/thrift/DemoClient.php
* /hbase/trunk/examples/thrift/DemoClient.pl
* /hbase/trunk/examples/thrift/DemoClient.py
* /hbase/trunk/examples/thrift/DemoClient.rb
* /hbase/trunk/examples/thrift/Makefile
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137297#comment-13137297 ]
stack commented on HBASE-4658:
------------------------------
The hbase-1744 work is done to the side of current thrift, IIRC. I'd say make note over there about integrating this change in. Can then do regen on commit of hbase-1744.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.2.patch
dhruba updated the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
Addressed Scott's review comments.
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.1.patch
dhruba requested code review of "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
The HBase Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is now exposed via Thrift.
TEST PLAN
run TestThriftServer
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3279/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199023#comment-13199023 ]
Phabricator commented on HBASE-4658:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
INLINE COMMENTS
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:497 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:520 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:537 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:557 It would be better to replace Put with 'mutation'
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460446#comment-13460446 ]
Hudson commented on HBASE-4658:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #185 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/185/])
HBASE-6806 HBASE-4658 breaks backward compatibility / example scripts (Revision 1388318)
Result = FAILURE
stack :
Files :
* /hbase/trunk/examples/thrift/DemoClient.cpp
* /hbase/trunk/examples/thrift/DemoClient.java
* /hbase/trunk/examples/thrift/DemoClient.php
* /hbase/trunk/examples/thrift/DemoClient.pl
* /hbase/trunk/examples/thrift/DemoClient.py
* /hbase/trunk/examples/thrift/DemoClient.rb
* /hbase/trunk/examples/thrift/Makefile
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.3.patch
dhruba updated the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
Incorporated feedback from tedyu. Thanks.
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136610#comment-13136610 ]
stack commented on HBASE-4658:
------------------------------
Is this patch missing the generated code? I'm good w/ it in 0.92.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199248#comment-13199248 ]
Hadoop QA commented on HBASE-4658:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513034/D1563.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -140 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationPeer
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/897//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/897//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/897//console
This message is automatically generated.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199022#comment-13199022 ]
Phabricator commented on HBASE-4658:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
INLINE COMMENTS
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:497 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:520 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:537 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:557 It would be better to replace Put with 'mutation'
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Lukas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457800#comment-13457800 ]
Lukas commented on HBASE-4658:
------------------------------
Making the 'attributes' argument would have been better. This breaks the thrift examples and also backward compatibility
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272575#comment-13272575 ]
Phabricator commented on HBASE-4658:
------------------------------------
dhruba has closed the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
REVISION DETAIL
https://reviews.facebook.net/D1563
To: tedyu, sc, dhruba
Cc: JIRA, sc, tedyu
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.3.patch
dhruba updated the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
Incorporated feedback from tedyu. Thanks.
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199926#comment-13199926 ]
dhruba borthakur commented on HBASE-4658:
-----------------------------------------
I think the unit test failures are not related to my patch. Does this mean that this patch is good to go?
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137291#comment-13137291 ]
Jonathan Gray commented on HBASE-4658:
--------------------------------------
Dhruba, it is thrift 0.7.0 (or at least it was last time I generated). If you don't have time today I can regenerate Hbase.java and commit this.
Re: HBASE-1744, will this change apply after that goes in? It seems like this change could be added on top of that change but that your current patch is based on the current thrift API?
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HBASE-4658:
------------------------------------
Status: Patch Available (was: Open)
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198319#comment-13198319 ]
Phabricator commented on HBASE-4658:
------------------------------------
sc has accepted the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Looks good to me
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:1300 I would prefer the style
for (Map.Entry<ByteBuffer, ByteBuffer> entry : attributes.entrySet()) {
...
}
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460269#comment-13460269 ]
stack commented on HBASE-4658:
------------------------------
The above comment from hudson is in wrong place. The parse found the second hbase jira referenced which is this one rather than HBASE-6806.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135087#comment-13135087 ]
Andrew Purtell commented on HBASE-4658:
---------------------------------------
+1 for updating Thrift with support for attributes on all of Get, Put, Scan, Delete, Increment, ...
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HBASE-4658:
------------------------------------
Attachment: ThriftPutAttributes1.txt
Added attribute passing to Scan, Get and Put calls via the Thrift interface
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199263#comment-13199263 ]
Zhihong Yu commented on HBASE-4658:
-----------------------------------
Test failures are unrelated.
+1 on patch v3.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199998#comment-13199998 ]
Hudson commented on HBASE-4658:
-------------------------------
Integrated in HBase-TRUNK #2653 (See [https://builds.apache.org/job/HBase-TRUNK/2653/])
HBASE-4658 Put attributes are not exposed via the ThriftServer (Dhruba)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136683#comment-13136683 ]
dhruba borthakur commented on HBASE-4658:
-----------------------------------------
This is complimentary to the things occuring in HBASE-1744. This just adds the Put attributes to the Put/Get/Scan call. There is no risk in this piece of code, so I am ok if you folks decide to put this into 0.92.
Stack: can the committer pl generate the generated code and commit it (the only generated file that changes is Hbase.java)? Alternatively, if somebody can tell me which version of thrift to use (and where to pick up that version of the thrift binary), I can upload the generated file as part of my patch too.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198318#comment-13198318 ]
Phabricator commented on HBASE-4658:
------------------------------------
sc has accepted the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Looks good to me
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:1300 I would prefer the style
for (Map.Entry<ByteBuffer, ByteBuffer> entry : attributes.entrySet()) {
...
}
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199948#comment-13199948 ]
Zhihong Yu commented on HBASE-4658:
-----------------------------------
Integrated to TRUNK.
Thanks for the patch, Dhruba.
Thanks for the review, Scott.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.3.patch
dhruba updated the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
Incorporated feedback from tedyu. Thanks.
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198317#comment-13198317 ]
Phabricator commented on HBASE-4658:
------------------------------------
sc has accepted the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Looks good to me
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:1300 I would prefer the style
for (Map.Entry<ByteBuffer, ByteBuffer> entry : attributes.entrySet()) {
...
}
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199020#comment-13199020 ]
Phabricator commented on HBASE-4658:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
INLINE COMMENTS
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:497 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:520 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:537 It would be better to replace Put with 'mutation'
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift:557 It would be better to replace Put with 'mutation'
REVISION DETAIL
https://reviews.facebook.net/D1563
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Lukas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457802#comment-13457802 ]
Lukas commented on HBASE-4658:
------------------------------
i go and buy an 'optional'.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.1.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.2.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ASF.LICENSE.NOT.GRANTED--D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136383#comment-13136383 ]
Jonathan Gray commented on HBASE-4658:
--------------------------------------
How does this relate to HBASE-1744? That's slated for 0.94, should we just put this in 0.92? And I guess we should ensure that attributes are supported over there.
I'm +1 on putting this in 0.92 since it makes it possible to add whatever we want without changing the API in 92 minor releases.
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HBASE-4658:
------------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4658:
-------------------------------
Attachment: D1563.2.patch
dhruba updated the revision "[jira] [HBASE-4658] Put attributes are not exposed via the ThriftServer".
Reviewers: tedyu, sc
Addressed Scott's review comments.
REVISION DETAIL
https://reviews.facebook.net/D1563
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4658) Put attributes are not exposed via
the ThriftServer
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200340#comment-13200340 ]
Hudson commented on HBASE-4658:
-------------------------------
Integrated in HBase-TRUNK-security #100 (See [https://builds.apache.org/job/HBase-TRUNK-security/100/])
HBASE-4658 Put attributes are not exposed via the ThriftServer (Dhruba)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
> Key: HBASE-4658
> URL: https://issues.apache.org/jira/browse/HBASE-4658
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, D1563.2.patch, D1563.2.patch, D1563.2.patch, D1563.3.patch, D1563.3.patch, D1563.3.patch, ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application can use to associate metadata with each put operation. This is not exposed via Thrift.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira