You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/08/27 22:22:19 UTC
[kudu-CR](gh-pages) [site] fix names on committers page
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14150
Change subject: [site] fix names on committers page
......................................................................
[site] fix names on committers page
A couple of names were not up-to-date.
Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
---
M committers.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14150/1
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](gh-pages) [site] fix names on committers page
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix names on committers page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14150/1/committers.md
File committers.md:
http://gerrit.cloudera.org:8080/#/c/14150/1/committers.md@16
PS1, Line 16: | adar | Adar Lieber-Dembo | VP, PMC |
Although technically correct (and this would please my wife greatly), the rest of my ASF information still reflects my old name. So don't update this yet; at some point I'll do it "atomically".
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:24:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14150
to look at the new patch set (#2).
Change subject: [site] fix name on committers page
......................................................................
[site] fix name on committers page
Keeping aligned with:
http://people.apache.org/committer-index.html#M
Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
---
M committers.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14150/2
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (525) has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (525)
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Thu, 29 Aug 2019 15:38:30 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 2: Code-Review+2
+2 for moving this quickly but probably best to wait for Misty's feedback.
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:31:02 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Wed, 28 Aug 2019 01:51:32 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 3:
> Patch Set 2: Code-Review+1
Thanks for the review Misty!
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (525)
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Thu, 29 Aug 2019 16:09:44 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14150/1/committers.md
File committers.md:
http://gerrit.cloudera.org:8080/#/c/14150/1/committers.md@16
PS1, Line 16: | adar | Adar Dembo | VP, PMC |
> Although technically correct (and this would please my wife greatly), the r
Done
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:30:02 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
[site] fix name on committers page
Keeping aligned with:
http://people.apache.org/committer-index.html#M
Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Reviewed-on: http://gerrit.cloudera.org:8080/14150
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M committers.md
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, but someone else must approve
Anonymous Coward (525): Looks good to me, but someone else must approve
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (525)
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
[kudu-CR](gh-pages) [site] fix name on committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14150 )
Change subject: [site] fix name on committers page
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d765a40e45537ade7a0479db1893e3f8128b544
Gerrit-Change-Number: 14150
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (525)
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Comment-Date: Thu, 29 Aug 2019 16:09:07 +0000
Gerrit-HasComments: No