[GitHub] [groovy] eric-milles commented on a change in pull request #1553: Implement GROOVY-9649: left-open and full-open ranges

[GitBox <gi...@apache.org>]

eric-milles commented on a change in pull request #1553:
URL: https://github.com/apache/groovy/pull/1553#discussion_r611073061



##########
File path: src/main/java/org/codehaus/groovy/ast/expr/RangeExpression.java
##########
@@ -27,26 +27,42 @@
  * <pre>for i in 0..10 {...}</pre>
  */
 public class RangeExpression extends Expression {
-
     private final Expression from;
     private final Expression to;
-    private final boolean inclusive;
+    private final boolean inclusive; // Kept to keep old code depending on this working

Review comment:
       Can this field be dropped and `isInclusive()` is implemented in terms of "right inclusivity"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org