You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 05:03:28 UTC
[GitHub] [spark] c21 opened a new pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
c21 opened a new pull request #31892:
URL: https://github.com/apache/spark/pull/31892
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR is to fix the LIMIT code-gen bug in https://issues.apache.org/jira/browse/SPARK-34796, where the counter variable from `BaseLimitExec` is not initialized but used in code-gen. This is because the limit counter variable will be used in upstream operators (LIMIT's child plan, e.g. `ColumnarToRowExec` operator for early termination), but in the same stage, there can be some operators doing the shortcut and not calling `BaseLimitExec`'s `doConsume()`, e.g. [HashJoin.codegenInner](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala#L402). So if we have query that `LocalLimit - BroadcastHashJoin - FileScan` in the same stage, the whole stage code-gen compilation will be failed.
Here is an example:
```
test("failed limit query") {
withTable("left_table", "empty_right_table", "output_table") {
spark.range(5).toDF("k").write.saveAsTable("left_table")
spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
spark.sql("CREATE TABLE output_table (k INT) USING parquet")
spark.sql(
s"""
|INSERT INTO TABLE output_table
|SELECT t1.k FROM left_table t1
|JOIN empty_right_table t2
|ON t1.k = t2.k
|LIMIT 3
|""".stripMargin)
}
}
}
```
Query plan:
```
Execute InsertIntoHadoopFsRelationCommand file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sql.SQLQuerySuite/output_table, false, Parquet, Map(path -> file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sql.SQLQuerySuite/output_table), Append, CatalogTable(
Database: default
Table: output_table
Created Time: Thu Mar 18 21:46:26 PDT 2021
Last Access: UNKNOWN
Created By: Spark 3.2.0-SNAPSHOT
Type: MANAGED
Provider: parquet
Location: file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sql.SQLQuerySuite/output_table
Schema: root
|-- k: integer (nullable = true)
), org.apache.spark.sql.execution.datasources.InMemoryFileIndex@b25d08b, [k]
+- *(3) Project [ansi_cast(k#228L as int) AS k#231]
+- *(3) GlobalLimit 3
+- Exchange SinglePartition, ENSURE_REQUIREMENTS, [id=#179]
+- *(2) LocalLimit 3
+- *(2) Project [k#228L]
+- *(2) BroadcastHashJoin [k#228L], [k#229L], Inner, BuildRight, false
:- *(2) Filter isnotnull(k#228L)
: +- *(2) ColumnarToRow
: +- FileScan parquet default.left_table[k#228L] Batched: true, DataFilters: [isnotnull(k#228L)], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sq..., PartitionFilters: [], PushedFilters: [IsNotNull(k)], ReadSchema: struct<k:bigint>
+- BroadcastExchange HashedRelationBroadcastMode(List(input[0, bigint, false]),false), [id=#173]
+- *(1) Filter isnotnull(k#229L)
+- *(1) ColumnarToRow
+- FileScan parquet default.empty_right_table[k#229L] Batched: true, DataFilters: [isnotnull(k#229L)], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sq..., PartitionFilters: [], PushedFilters: [IsNotNull(k)], ReadSchema: struct<k:bigint>
```
Codegen failure - https://gist.github.com/c21/ea760c75b546d903247582be656d9d66 .
The uninitialized variable `_limit_counter_1` from `LocalLimitExec` is referenced in `ColumnarToRowExec`, but `BroadcastHashJoinExec` does not call `LocalLimitExec.doConsume()` to initialize the counter variable.
The fix is to move the counter variable initialization to `doProduce()`, as in whole stage code-gen framework, `doProduce()` will definitely be called if upstream operators `doProduce()`/`doConsume()` is called.
Note: this only happens in AQE disabled case, because we have an AQE optimization rule [EliminateUnnecessaryJoin](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala#L69) to change the whole query to an empty `LocalRelation` if inner join broadcast side is empty with AQE enabled.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix query failure.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit test in `SQLQuerySuite.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802583045
> @maropu - Based on my knowledge I don't think so. The shortcut for HashJoin (not calling parent's doConsume()) was added in 3.1 - 08b951b . I am not aware of any other operator's shortcut execution.
Ah, I see. It looks interesting. I thought that `doConsume` would always be called from a upper node, but now that assumption is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802573189
How about `branch-3.0` and `branch-2.4`? They have this issue, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597423584
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(df2, Seq(Row(2, 1, 1), Row(4, 2, 2)))
}
}
+
+ test("SPARK-34796: Avoid code-gen compilation error for LIMIT query") {
+ withTable("left_table", "empty_right_table", "output_table") {
+ spark.range(5).toDF("k").write.saveAsTable("left_table")
+ spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
+
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+ spark.sql("CREATE TABLE output_table (k INT) USING parquet")
+ spark.sql(
+ """
+ |INSERT INTO TABLE output_table
+ |SELECT t1.k FROM left_table t1
+ |JOIN empty_right_table t2
+ |ON t1.k = t2.k
+ |LIMIT 3
+ """.stripMargin)
Review comment:
nit: how about checking `checkAnswer(spark.table("output_table"), Row(...) ...)` just in case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597422339
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(df2, Seq(Row(2, 1, 1), Row(4, 2, 2)))
}
}
+
+ test("SPARK-34796: Avoid code-gen compilation error for LIMIT query") {
+ withTable("left_table", "empty_right_table", "output_table") {
+ spark.range(5).toDF("k").write.saveAsTable("left_table")
+ spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
+
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+ spark.sql("CREATE TABLE output_table (k INT) USING parquet")
+ spark.sql(
+ """
+ |INSERT INTO TABLE output_table
Review comment:
is INSERT necessary to reproduce the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597433798
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(df2, Seq(Row(2, 1, 1), Row(4, 2, 2)))
}
}
+
+ test("SPARK-34796: Avoid code-gen compilation error for LIMIT query") {
+ withTable("left_table", "empty_right_table", "output_table") {
+ spark.range(5).toDF("k").write.saveAsTable("left_table")
+ spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
+
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+ spark.sql("CREATE TABLE output_table (k INT) USING parquet")
+ spark.sql(
+ """
+ |INSERT INTO TABLE output_table
+ |SELECT t1.k FROM left_table t1
+ |JOIN empty_right_table t2
+ |ON t1.k = t2.k
+ |LIMIT 3
+ """.stripMargin)
Review comment:
@maropu - here we are inner-joining an empty table `empty_right_table`, so the output table still has nothing after query. Shall we check answer as well? I am fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802559650
cc @cloud-fan, @maropu and @HyukjinKwon to take a look if you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31892:
URL: https://github.com/apache/spark/pull/31892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-803239233
Thank you @maropu and @cloud-fan for review. Will submit a PR shortly for branch 3.1. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802573189
How about `branch-3.0` and `branch-2.4`? They have the issue, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597457285
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(df2, Seq(Row(2, 1, 1), Row(4, 2, 2)))
}
}
+
+ test("SPARK-34796: Avoid code-gen compilation error for LIMIT query") {
+ withTable("left_table", "empty_right_table", "output_table") {
+ spark.range(5).toDF("k").write.saveAsTable("left_table")
+ spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
+
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+ spark.sql("CREATE TABLE output_table (k INT) USING parquet")
+ spark.sql(
+ """
+ |INSERT INTO TABLE output_table
+ |SELECT t1.k FROM left_table t1
+ |JOIN empty_right_table t2
+ |ON t1.k = t2.k
+ |LIMIT 3
+ """.stripMargin)
Review comment:
okay, looks fine as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597426996
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(df2, Seq(Row(2, 1, 1), Row(4, 2, 2)))
}
}
+
+ test("SPARK-34796: Avoid code-gen compilation error for LIMIT query") {
+ withTable("left_table", "empty_right_table", "output_table") {
+ spark.range(5).toDF("k").write.saveAsTable("left_table")
+ spark.range(0).toDF("k").write.saveAsTable("empty_right_table")
+
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+ spark.sql("CREATE TABLE output_table (k INT) USING parquet")
+ spark.sql(
+ """
+ |INSERT INTO TABLE output_table
Review comment:
@cloud-fan - yes I think so.
For query:
```
SELECT t1.k FROM left_table t1
JOIN empty_right_table t2
ON t1.k = t2.k
LIMIT 3
```
The physical plan:
```
CollectLimit 3
+- *(2) Project [k#228L]
+- *(2) BroadcastHashJoin [k#228L], [k#229L], Inner, BuildRight, false
:- *(2) Filter isnotnull(k#228L)
: +- *(2) ColumnarToRow
: +- FileScan parquet default.left_table[k#228L] Batched: true, DataFilters: [isnotnull(k#228L)], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sq..., PartitionFilters: [], PushedFilters: [IsNotNull(k)], ReadSchema: struct<k:bigint>
+- BroadcastExchange HashedRelationBroadcastMode(List(input[0, bigint, false]),false), [id=#148]
+- *(1) Filter isnotnull(k#229L)
+- *(1) ColumnarToRow
+- FileScan parquet default.empty_right_table[k#229L] Batched: true, DataFilters: [isnotnull(k#229L)], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/Users/chengsu/spark/sql/core/spark-warehouse/org.apache.spark.sq..., PartitionFilters: [], PushedFilters: [IsNotNull(k)], ReadSchema: struct<k:bigint>
```
This is not reproduced any more as there's no code-gen `BaseLimitExec` after `BroadcastHashJoin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-803228511
Thanks! Merged to master. The commit has a conflict with branch-3.1, so could you open a backport PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802577267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 edited a comment on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 edited a comment on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802578765
> How about branch-3.0 and branch-2.4? They have this issue, too?
@maropu - Based on my knowledge I don't think so. The shortcut for `HashJoin` (not calling parent's doConsume()) was added in 3.1 - https://github.com/apache/spark/commit/08b951b1cb58cea2c34703e43202fe7c84725c8a . I am not aware of any other operator's shortcut execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31892: [SPARK-34796][SQL] Initialize counter variable for LIMIT code-gen in doProduce()
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802578765
> How about branch-3.0 and branch-2.4? They have this issue, too?
Based on my knowledge I don't think so. The shortcut for `HashJoin` (not calling parent's doConsume()) was added in 3.1 - https://github.com/apache/spark/commit/08b951b1cb58cea2c34703e43202fe7c84725c8a . I am not aware of any other operator's shortcut execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org