You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2019/02/22 13:34:00 UTC
[jira] [Updated] (TINKERPOP-2153) Remove unused parameter from
ResponseMessageSerializer
[ https://issues.apache.org/jira/browse/TINKERPOP-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stephen mallette updated TINKERPOP-2153:
----------------------------------------
Labels: breaking (was: )
> Remove unused parameter from ResponseMessageSerializer
> ------------------------------------------------------
>
> Key: TINKERPOP-2153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2153
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.4.0
> Reporter: Jorge Bay
> Priority: Minor
> Labels: breaking
>
> When implementing GraphBinary as part of TINKERPOP-1942, the idea was to make {{RequestMessageSerializer}} and {{ResponseMessageSerializer}} implement {{TypeSerializer<T>}} interface, but was later disregarded as those are top level serializers (Request/Response can't be nested within another type).
> As a result, the {{nullable}} parameter was removed from {{RequestMessageSerializer}} but I've forgot to do it for {{ResponseMessageSerializer}}. We should remove it as it's never used, the question is whether we can do this change as part of a patch release, as it involves API changes. Given that GraphBinary is still on its early stages and {{ResponseMessageSerializer}} is not designed to be inherited from / all called, I think we should change the method signature asap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)