[GitHub] bwsw commented on issue #2893: ApiServer: signature v3 to accept more formats

[GitBox <gi...@apache.org>]

bwsw commented on issue #2893: ApiServer: signature v3 to accept more formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-435735815
 
 
   @DaanHoogland @rhtyd @greut 
   Unit-tests buggy. Take a look:
   
   ```java
   @Test
       public void zonedTimeFormatIsoNoColonZMs() throws ParseException {
           Date time = new Date();
           DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSZ");
           String str = OffsetDateTime.now().format(formatter);
   
           Date dtParsed = DateUtil.parseTZDateString(str);
   
           assertEquals(str, time.toString(), dtParsed.toString());
       }
   ```
   
   This unittest is obviously buggy. Because there are two times when objects are used to get current DT, as a result, sometimes it fails.
   
   https://travis-ci.org/apache/cloudstack/jobs/450628551#L1047
   
   Need a codefix or PR reverted and fixed. PR was merged recently. Now CS fails to build sometimes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services