You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Agron Limani (JIRA)" <ji...@apache.org> on 2009/12/21 10:48:18 UTC
[jira] Created: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Enable an auto generated response to an HTTP OPTIONS request
------------------------------------------------------------
Key: CLEREZZA-48
URL: https://issues.apache.org/jira/browse/CLEREZZA-48
Project: Clerezza
Issue Type: Bug
Reporter: Agron Limani
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür reopened CLEREZZA-48:
----------------------------------------
Assignee: (was: Reto Bachmann-Gmür)
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani updated CLEREZZA-48:
---------------------------------
Attachment: AutoGeneratedOptionsTest.java
this test should pass
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür reassigned CLEREZZA-48:
------------------------------------------
Assignee: Reto Bachmann-Gmür
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür closed CLEREZZA-48.
--------------------------------------
great! thanks for the patch!
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani updated CLEREZZA-48:
---------------------------------
Attachment: org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-48) Enable an auto generated response
to an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797158#action_12797158 ]
Reto Bachmann-Gmür commented on CLEREZZA-48:
--------------------------------------------
problem applying second path:
...
|Index: issues/CLEREZZA-48/org.apache.clerezza.triaxrs/org.apache.clerezza.triaxrs/src/test/java/org/apache/clerezza/triaxrs/blackbox/AutoGeneratedResponseTest.java
|===================================================================
|--- issues/CLEREZZA-48/org.apache.clerezza.triaxrs/org.apache.clerezza.triaxrs/src/test/java/org/apache/clerezza/triaxrs/blackbox/AutoGeneratedResponseTest.java (revision 893466)
|+++ issues/CLEREZZA-48/org.apache.clerezza.triaxrs/org.apache.clerezza.triaxrs/src/test/java/org/apache/clerezza/triaxrs/blackbox/AutoGeneratedResponseTest.java (working copy)
--------------------------
File to patch:
Skip this patch? [y]
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-48) Enable an auto generated response
to an HTTP OPTIONS request
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793604#action_12793604 ]
Hasan commented on CLEREZZA-48:
-------------------------------
reviewing
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani updated CLEREZZA-48:
---------------------------------
Attachment: org.clerezza.apache.triaxrs-CLEREZZA-48.patch
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-48) Enable an auto generated response
to an HTTP OPTIONS request
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793978#action_12793978 ]
Hasan commented on CLEREZZA-48:
-------------------------------
AutoGeneratedOptionsTest
- a short description (as comments) about the purpose of the test would be fine
and refer to relevant sections in JAX-RS specification, e.g., 3.3.5
- suggest to rename the test class to AutoGeneratedResponseTest
and the method name to testResponseToOptionsRequest
- suggest to avoid printing messages in test, use assert instead
In this particular case, replace system.out.println with a variable assignment
which can be later tested whether or not this variable should be assigned in
specific test.
- for this test, it's not necessary to define propfind method, you can use existing
http methods like GET, PUT, etc.
Review to be continued by Reto BG
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani resolved CLEREZZA-48.
----------------------------------
Resolution: Fixed
- implemented the changes from the review comments except i still use the PROPFIND annotation
- changed the class ResponseImpl.java from package org.apache.clerezza.triaxrs.mock (because the addHeader() method wasn't implemented correctly) for that reason i also had to change some of the test classes
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-48) Enable an auto generated response
to an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793997#action_12793997 ]
Reto Bachmann-Gmür commented on CLEREZZA-48:
--------------------------------------------
please patch issue branch for:
- the new test to pass
- no longer need changes to ResponseProcessor, instead add headers to response object
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani resolved CLEREZZA-48.
----------------------------------
Resolution: Fixed
-WebRequestImpl.java
implemented method public String getMethod()
-RootResourceExecutorImpl.java
impemented method private ProcessableResponse responsDefaultOption(...)
-ResponseProcessor.java
added change to method static void processJaxResponse(...), so that if an OPTIONS request is processed an ALLOW header is added to the response
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani updated CLEREZZA-48:
---------------------------------
Attachment: org.clerezza.apache.triaxrs-CLEREZZA-48_3.patch
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür reassigned CLEREZZA-48:
------------------------------------------
Assignee: Reto Bachmann-Gmür
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLEREZZA-48) Enable an auto generated response to
an HTTP OPTIONS request
Posted by "Agron Limani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agron Limani updated CLEREZZA-48:
---------------------------------
Attachment: (was: org.clerezza.apache.triaxrs-CLEREZZA-48_2.patch)
> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
> Key: CLEREZZA-48
> URL: https://issues.apache.org/jira/browse/CLEREZZA-48
> Project: Clerezza
> Issue Type: Bug
> Reporter: Agron Limani
> Assignee: Reto Bachmann-Gmür
> Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch, org.clerezza.apache.triaxrs-CLEREZZA-48_3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.