You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/24 15:26:50 UTC
[GitHub] [flink] becketqin commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().
becketqin commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648890887
@twalthr I think the clearest naming is either `StreamExecutionEnvironment#dataStreamFromSource()` or `DataStream#fromSource()`. But given the current status, I agree that `StreamExecutionEnvironment#fromSource()` is better than just `source()`. At least this would give a consistent style after we deprecate `readFile()`, `addSource()` and `createInput()`. I'll update the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org