You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2016/03/23 18:19:50 UTC

mesos git commit: Replaced const ref to temporary in tests for consistency.

Repository: mesos
Updated Branches:
  refs/heads/master d687d41ff -> 459f2a64c


Replaced const ref to temporary in tests for consistency.

Review: https://reviews.apache.org/r/45001/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/459f2a64
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/459f2a64
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/459f2a64

Branch: refs/heads/master
Commit: 459f2a64c791caacf1f9c7c999a4b1f7b608396f
Parents: d687d41
Author: Jojy Varghese <jo...@mesosphere.io>
Authored: Wed Mar 23 10:19:35 2016 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Wed Mar 23 10:19:35 2016 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp | 2 +-
 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/459f2a64/3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp b/3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp
index daa46e0..5bd154e 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp
@@ -222,7 +222,7 @@ TEST_F(RmdirTest, RemoveDirectoryWithNoTargetSymbolicLink)
   const string newDirectory = path::join(os::getcwd(), "newDirectory");
   ASSERT_SOME(os::mkdir(newDirectory));
 
-  const string& link = path::join(newDirectory, "link");
+  const string link = path::join(newDirectory, "link");
 
   // Create a symlink to non-existent file 'tmp'.
   ASSERT_SOME(fs::symlink("tmp", link));

http://git-wip-us.apache.org/repos/asf/mesos/blob/459f2a64/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp b/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
index a69fd2d..9bd34c7 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
@@ -166,7 +166,7 @@ TEST_F(OsTest, Nonblock)
 // non-existing file.
 TEST_F(OsTest, Size)
 {
-  const string& file = path::join(os::getcwd(), UUID::random().toString());
+  const string file = path::join(os::getcwd(), UUID::random().toString());
 
   const Bytes size = 1053;
 
@@ -179,7 +179,7 @@ TEST_F(OsTest, Size)
 
   EXPECT_ERROR(os::stat::size("aFileThatDoesNotExist"));
 
-  const string& link = path::join(os::getcwd(), UUID::random().toString());
+  const string link = path::join(os::getcwd(), UUID::random().toString());
 
   ASSERT_SOME(fs::symlink(file, link));