You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/23 14:30:44 UTC
[GitHub] [pulsar] lhotari opened a new issue #8362: [Github Flow] pom.xml change is considered a documentation change
lhotari opened a new issue #8362:
URL: https://github.com/apache/pulsar/issues/8362
The current Github Flow's "Check if this pull request only changes documentation" step (id=docs) considers a pom.xml change as a documentation change. When there's a commit that doesn't contain other changes, all tests will be skipped.
**Expected behavior**
pom.xml shouldn't be considered as a documentation change
**Additional context**
https://github.com/apache/pulsar/pull/8351 passed the checks without running any tests. Example: https://github.com/apache/pulsar/runs/1295771802
There's https://github.com/apache/pulsar/pull/8361 to fix the broken state of CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #8362:
URL: https://github.com/apache/pulsar/issues/8362#issuecomment-716274008
Thanks @lhotari for the help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #8362:
URL: https://github.com/apache/pulsar/issues/8362#issuecomment-715900864
I pushed a fix to diff-only https://github.com/apache/pulsar-test-infra/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai closed issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
jiazhai closed issue #8362:
URL: https://github.com/apache/pulsar/issues/8362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #8362:
URL: https://github.com/apache/pulsar/issues/8362#issuecomment-715897302
It seems that there's a bug in https://github.com/apache/pulsar-test-infra/blob/master/diff-only/entrypoint.sh .
it doesn't seem to handle the case when a commit includes changes only in the root directory
some log rows:
```
2020-10-23T01:26:37.4699758Z HEAD
2020-10-23T01:26:37.7372668Z CHANGED_DIRS are :
2020-10-23T01:26:37.7376810Z Changes only in site2 deployment .asf.yaml .ci ct.yaml, setting 'changed_only' to 'yes'
2020-10-23T01:26:38.9524837Z Post job cleanup.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #8362:
URL: https://github.com/apache/pulsar/issues/8362#issuecomment-715508740
It seems that this script is eventually used in the checks:
https://github.com/apache/pulsar-test-infra/blob/master/diff-only/entrypoint.sh
it's missing a feature to specify exception patterns, I guess. If the root pom.xml file changes, it's not a doc change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #8362: [Github Flow] pom.xml change is considered a documentation change
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #8362:
URL: https://github.com/apache/pulsar/issues/8362#issuecomment-715876753
To debug the issue I stored the logs from the pipeline to a gist: https://gist.github.com/lhotari/a4b7aa97d240b6914cfbb3935776c2ea#file-ci_bug_logs-txt-L675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org