You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/10/18 15:46:48 UTC
[GitHub] cloudstack pull request: Load-mysql-driver-before-creating-datasou...
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/946
Load-mysql-driver-before-creating-datasource
When deploying ACS as a WAR file in a vanilla tomcat installation, I always get an error reporting that the JDBC driver for MySQL can't be found. This PR loads said driver before establishing a connection.
I tried to figure out how this is done in the ACS rpm but I couldn't. Therefore I open this PR to enable anyone that wants to deploy ACS as a WAR file.
I have tested this PR by deploying the resulting WAR several times, and I have to say to reviewers, that the war needs to be rename to client.war, otherwise the UI will not work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguelaferreira/cloudstack load-mysql-driver
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #946
----
commit ca8d350bf12d4e9f2e977096c8b04c49b4f3d188
Author: Miguel Ferreira <mi...@me.com>
Date: 2015-10-18T13:42:19Z
Load-mysql-driver-before-creating-datasource
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Load mysql driver before creating datasou...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Load mysql driver before creating datasou...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/946#issuecomment-149201301
Travis is reporting a missing dependency because the mysql connector jar is not being loaded. That should be fixed in PR #947. Closing this PR and moving the commit to PR #947
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Load-mysql-driver-before-creating-datasou...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/946#issuecomment-149170422
PR #948 tries to fix the issue that travis faced while building this PR.
As for the Jenkins build I've scanned through the output and couldn't find the reasons why it is marked "UNSTBALE"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Load mysql driver before creating datasou...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/946#issuecomment-149170996
@remibergsma will do that, also because the commit message got the '-' in between the words!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Load-mysql-driver-before-creating-datasou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/946#issuecomment-149170855
@miguelaferreira You may want to force push again to see if Jenkins will be happy this time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---